Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log: the log GC does not work for secondary loggers #40974

Closed
knz opened this issue Sep 23, 2019 · 1 comment · Fixed by #40993 or #41020
Closed

log: the log GC does not work for secondary loggers #40974

knz opened this issue Sep 23, 2019 · 1 comment · Fixed by #40993 or #41020
Labels
A-logging In and around the logging infrastructure. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@knz
Copy link
Contributor

knz commented Sep 23, 2019

There's a channel gcNotify in each logger object, both main and secondary.

Today when any logger creates a new file it tickles the gcNotify of the main logger, which then proceeds to GC just the main logger.

So the secondary loggers do not get GC'ed.
@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-logging In and around the logging infrastructure. labels Sep 23, 2019
@knz
Copy link
Contributor Author

knz commented Sep 23, 2019

cc @tbg

This was referenced Sep 23, 2019
Merged
Merged
@knz knz mentioned this issue Sep 24, 2019
Merged
@craig craig bot closed this as completed in 83eb885 Sep 24, 2019
craig bot pushed a commit that referenced this issue Oct 17, 2019
@knz @jordanlewis
Merge #40993 #41654
0e655a3 
40993: util/log: refactor and bug fixes r=knz a=knz

Fixes #40983.
Fixes #40973.
Fixes #40974.
Fixes #41231.

I might also want to add code to clean up #40972, #40982 and #40990 provided I receive some guidance from @tbg or someone familiar with the log package.


41654: parser: fix telemetry link for materialized views r=jordanlewis a=jordanlewis

This commit fixes the error message that you get if you try to create a
materialized view to point at the right GitHub issue.

Release note: None

Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-logging In and around the logging infrastructure. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
1 participant
@knz