pgwire: TimeZone ParameterStatus field incorrect with offsets

[otan]

Found in #42376.

When using SET TIME ZONE +3 on initialisation or after changes over pgwire, the output in ParameterStatus is mismatching:

# cockroach
{"Type":"ParameterStatus","Name":"TimeZone","Value":"6"}
# postgres
{"Type":"ParameterStatus","Name":"TimeZone","Value":"\u003c+06\u003e-06"}

Furthermore, adding timezones such as -7.55 is incorrect.

See tests in pkg/sql/pgwire/testdata/pgtest/connection_params for more info.

Epic CRDB-8948

[github-actions]

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
5 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

[knz]

still current

[RichardJCai]

I believe this is because of timezones are formatted in the respective databases.

CRDB

demo@127.0.0.1:26257/movr> show timezone;
  timezone
------------
  -11.5
(1 row)

PG

rcai=# show timezone;
    TimeZone
----------------
 <-11:30>+11:30
(1 row)

Not exactly sure why PG formats like this

rcai=# set time zone 11;
SET
rcai=# show timezone;
 TimeZone
----------
 <+11>-11
(1 row)

rcai=# set timezone = -12;
SET
rcai=# show timezone;
 TimeZone
----------
 <-12>+12
(1 row)

Also with intervals:

rcai=# sET TIME ZONE INTERVAL  '1 hour';
SET
rcai=# show timezone;
 TimeZone
----------
 <+01>-01

demo@127.0.0.1:26257/movr> sET TIME ZONE INTERVAL  '1 hour';
warning: cannot save command-line history: write_history: illegal byte sequence

SET

Time: 2ms total (execution 0ms / network 1ms)

demo@127.0.0.1:26257/movr> show timezone;
   timezone
--------------
  '01:00:00'
(1 row)
Time: 1ms total (execution 1ms / network 0ms)

[otan]

@RichardJCai i believe you have fixed this?

[otan]

resolved by #70716