Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: fix timezone formatting for GMT offsets #70716

Merged

Conversation

RichardJCai
Copy link
Contributor

Release note (sql change): If the time zone is set in a GMT offset,
for example +7 or -11, the timezone will be formatted as
<+07>-07 and <-11>+11 respectively instead of +7, -11.

This most notably shows up when doing SHOW TIME ZONE.

@RichardJCai RichardJCai requested a review from otan September 24, 2021 19:35
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@RichardJCai RichardJCai force-pushed the fix_time_zone_formatting_09242021 branch from c95d666 to b78b1de Compare September 24, 2021 19:44
@RichardJCai RichardJCai force-pushed the fix_time_zone_formatting_09242021 branch from b78b1de to 740d7e3 Compare September 30, 2021 19:10
@blathers-crl blathers-crl bot requested a review from otan September 30, 2021 19:10
@RichardJCai RichardJCai force-pushed the fix_time_zone_formatting_09242021 branch 2 times, most recently from a02f8d0 to 79076de Compare September 30, 2021 20:11
pkg/util/timeutil/time_zone_util.go Outdated Show resolved Hide resolved
pkg/util/timeutil/time_zone_util.go Outdated Show resolved Hide resolved
@RichardJCai RichardJCai force-pushed the fix_time_zone_formatting_09242021 branch from 79076de to 5dc90cc Compare October 4, 2021 19:29
@blathers-crl blathers-crl bot requested a review from otan October 4, 2021 19:29
@RichardJCai RichardJCai force-pushed the fix_time_zone_formatting_09242021 branch from 5dc90cc to 5b479dc Compare October 4, 2021 19:31
@RichardJCai RichardJCai marked this pull request as ready for review October 4, 2021 19:33
@RichardJCai RichardJCai force-pushed the fix_time_zone_formatting_09242021 branch 2 times, most recently from 66e9b54 to af9fbf5 Compare October 4, 2021 21:18
pkg/sql/pgwire/testdata/pgtest/param_status Show resolved Hide resolved
pkg/sql/pgwire/testdata/pgtest/param_status Outdated Show resolved Hide resolved
pkg/util/timeutil/time_zone_util.go Outdated Show resolved Hide resolved
@RichardJCai RichardJCai force-pushed the fix_time_zone_formatting_09242021 branch from af9fbf5 to a7f0361 Compare October 5, 2021 16:20
@blathers-crl blathers-crl bot requested a review from otan October 5, 2021 16:20
Release note (sql change): If the time zone is set in a GMT offset,
for example +7 or -11, the timezone will be formatted as
<+07>-07 and <-11>+11 respectively instead of +7, -11.

This most notably shows up when doing SHOW TIME ZONE.
@RichardJCai RichardJCai force-pushed the fix_time_zone_formatting_09242021 branch from a7f0361 to 132527e Compare October 5, 2021 18:43
Copy link
Contributor

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

pkg/sql/pgwire/testdata/pgtest/param_status Show resolved Hide resolved
@RichardJCai
Copy link
Contributor Author

TFTR!

bors r=otan

@craig
Copy link
Contributor

craig bot commented Oct 5, 2021

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants