-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: fix timezone formatting for GMT offsets #70716
Merged
craig
merged 1 commit into
cockroachdb:master
from
RichardJCai:fix_time_zone_formatting_09242021
Oct 5, 2021
Merged
sql: fix timezone formatting for GMT offsets #70716
craig
merged 1 commit into
cockroachdb:master
from
RichardJCai:fix_time_zone_formatting_09242021
Oct 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c95d666
to
b78b1de
Compare
otan
reviewed
Sep 26, 2021
b78b1de
to
740d7e3
Compare
a02f8d0
to
79076de
Compare
otan
reviewed
Sep 30, 2021
79076de
to
5dc90cc
Compare
5dc90cc
to
5b479dc
Compare
66e9b54
to
af9fbf5
Compare
otan
reviewed
Oct 4, 2021
af9fbf5
to
a7f0361
Compare
Release note (sql change): If the time zone is set in a GMT offset, for example +7 or -11, the timezone will be formatted as <+07>-07 and <-11>+11 respectively instead of +7, -11. This most notably shows up when doing SHOW TIME ZONE.
a7f0361
to
132527e
Compare
otan
approved these changes
Oct 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
TFTR! bors r=otan |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note (sql change): If the time zone is set in a GMT offset,
for example +7 or -11, the timezone will be formatted as
<+07>-07 and <-11>+11 respectively instead of +7, -11.
This most notably shows up when doing SHOW TIME ZONE.