-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest: tpcc/mixed-headroom/n5cpu16 failed #43110
Comments
(roachtest).tpcc/mixed-headroom/n5cpu16 failed on master@2f1e342c386973c35246bef68c177fcd0b8b609b:
Repro
Artifacts: /tpcc/mixed-headroom/n5cpu16
powered by pkg/cmd/internal/issues |
(roachtest).tpcc/mixed-headroom/n5cpu16 failed on master@277e28b2ea78929563e85cb1c9efc573f37408a4:
Repro
Artifacts: /tpcc/mixed-headroom/n5cpu16
powered by pkg/cmd/internal/issues |
(roachtest).tpcc/mixed-headroom/n5cpu16 failed on master@dd9b1c1f40dda59ee9d446416106d311ae5ce1e6:
Repro
Artifacts: /tpcc/mixed-headroom/n5cpu16
powered by pkg/cmd/internal/issues |
(roachtest).tpcc/mixed-headroom/n5cpu16 failed on master@319080c701cb4e13c347e86c4afb2f1c2af78def:
Repro
Artifacts: /tpcc/mixed-headroom/n5cpu16
powered by pkg/cmd/internal/issues |
(roachtest).tpcc/mixed-headroom/n5cpu16 failed on master@a3f81bcbef596f8b8134641526a87f27c4ad8082:
Repro
Artifacts: /tpcc/mixed-headroom/n5cpu16
powered by pkg/cmd/internal/issues |
(roachtest).tpcc/mixed-headroom/n5cpu16 failed on master@c172b37ec3316ec982e1ee92d4414a76823680e6:
Repro
Artifacts: /tpcc/mixed-headroom/n5cpu16
powered by pkg/cmd/internal/issues |
(roachtest).tpcc/mixed-headroom/n5cpu16 failed on master@2ddb82b2a8fff0c4e42169cf4e610d33a0fbd2d3:
Repro
Artifacts: /tpcc/mixed-headroom/n5cpu16
powered by pkg/cmd/internal/issues |
(roachtest).tpcc/mixed-headroom/n5cpu16 failed on master@d54e001248f233734ff926daef5470487c5616b0:
Repro
Artifacts: /tpcc/mixed-headroom/n5cpu16
powered by pkg/cmd/internal/issues |
(roachtest).tpcc/mixed-headroom/n5cpu16 failed on master@8f946b8bb62629002c5e958373b81ca9e1920dd6:
Repro
Artifacts: /tpcc/mixed-headroom/n5cpu16
powered by pkg/cmd/internal/issues |
(roachtest).tpcc/mixed-headroom/n5cpu16 failed on master@edd46b1405b7928760b65ec8aad59fd22a8adb6b:
Repro
Artifacts: /tpcc/mixed-headroom/n5cpu16
powered by pkg/cmd/internal/issues |
(roachtest).tpcc/mixed-headroom/n5cpu16 failed on master@f1f15250871d124178f40bf340ef48719b50e7e5:
Repro
Artifacts: /tpcc/mixed-headroom/n5cpu16
powered by pkg/cmd/internal/issues |
(roachtest).tpcc/mixed-headroom/n5cpu16 failed on master@0d1ae9cbc49518180e68aa0bfbf982d73854ddae:
Repro
Artifacts: /tpcc/mixed-headroom/n5cpu16
powered by pkg/cmd/internal/issues |
(roachtest).tpcc/mixed-headroom/n5cpu16 failed on master@a99740bb34c03ab3af7558129edce9c17c88d4f9:
Repro
Artifacts: /tpcc/mixed-headroom/n5cpu16
powered by pkg/cmd/internal/issues |
(roachtest).tpcc/mixed-headroom/n5cpu16 failed on master@8facb469d66426a3f372a1aed4ea6f34e287b501:
Repro
Artifacts: /tpcc/mixed-headroom/n5cpu16
powered by pkg/cmd/internal/issues |
(roachtest).tpcc/mixed-headroom/n5cpu16 failed on master@7906cbe3d9c615430f6e892a42e6bccdad2aff00:
Repro
Artifacts: /tpcc/mixed-headroom/n5cpu16
powered by pkg/cmd/internal/issues |
(roachtest).tpcc/mixed-headroom/n5cpu16 failed on master@f180501b7c2ccb946d7f7c8944d5509b87cb0394:
Repro
Artifacts: /tpcc/mixed-headroom/n5cpu16
powered by pkg/cmd/internal/issues |
(roachtest).tpcc/mixed-headroom/n5cpu16 failed on 43008@b555d16b4455f7122f4211082512820742f8116f:
Repro
Artifacts: /tpcc/mixed-headroom/n5cpu16
powered by pkg/cmd/internal/issues |
(roachtest).tpcc/mixed-headroom/n5cpu16 failed on master@52261c39c65aecf960e3c8d54089a66d378af610:
Repro
Artifacts: /tpcc/mixed-headroom/n5cpu16
powered by pkg/cmd/internal/issues |
(roachtest).tpcc/mixed-headroom/n5cpu16 failed on master@e2c2be6cbef07c7f2ee6341816f81f72a206c32a:
Repro
Artifacts: /tpcc/mixed-headroom/n5cpu16
powered by pkg/cmd/internal/issues |
(roachtest).tpcc/mixed-headroom/n5cpu16 failed on master@96d7e50acfaa63b5b60addd7cec8e750a4a4d333:
Repro
Artifacts: /tpcc/mixed-headroom/n5cpu16
powered by pkg/cmd/internal/issues |
(roachtest).tpcc/mixed-headroom/n5cpu16 failed on master@3bb183403b4bc75c25fbcfc69d7d35de76d2b984:
|
(roachtest).tpcc/mixed-headroom/n5cpu16 failed on master@a5b42be47cf47206d2343f40bbaf445f387f3890:
|
(roachtest).tpcc/mixed-headroom/n5cpu16 failed on master@c76ad970e73e606bc55a372d93f9d2d6acb32c9c:
|
@asubiotto there are some concerning failures here:
but also from one higher up:
There are some similar failures above, the first one on 1/16: #43110 (comment) Looks like we ought to stress this baby |
No I'm actually had just a few failed attempts at running this today (nothing interesting.. just hard to build the right binaries and my gceworker is old enough to have mismatching kernel versions, etc etc) edit: my overnight run is http://35.229.40.30:8080/ |
They all failed exactly with these errors above:
This was at e2c2be6. I will now try the parent of 379fc8f (the commit containing #42969). |
One out of five runs is still outstanding, but four already passed. Pretty sure pre-Andrei it's not broken (sorry buddy) Going to try 379fc8f now. |
Yeah first one already failed:
@andreimatei that seems to make it official. Note that there were other commits in that merge, but of all of them only #43989 remotely has the potential to have caused this bug, and I really don't think that one's it. I'm out for the rest of the day, so I won't be looking until next week. I guess we're pretty confident that we'll find out the root cause in due course since we have a <2h repro cycle and know the exact commit that caused the problem. tobias-1579868169-05-n5cpu16 is one cluster that has this problem. Any other tobias- clusters that are left after http://35.229.40.30:8080/ goes unresponsive will have failed the run, too. Just in case either you or @nvanbenschoten want to dig later today. |
Ugh. I'll rollback something and see what's up. Thanks for looking!
…On Fri, Jan 24, 2020 at 8:18 AM Tobias Grieger ***@***.***> wrote:
Yeah first one already failed:
ERROR: duplicate key value (o_w_id,o_d_id,o_id)=(128,3,3010) violates
unique constraint "primary" (SQLSTATE 23505)
@andreimatei <https://github.com/andreimatei> that seems to make it
official. Note that there were other commits in that merge, but of all of
them only #43989 <#43989>
remotely has the potential to have caused this bug, and I really don't
think that one's it.
I'm out for the rest of the day, so I won't be looking until next week. I
guess we're pretty confident that we'll find out the root cause in due
course since we have a <2h repro cycle and know the exact commit that
caused the problem. tobias-1579868169-05-n5cpu16 is one cluster that has
this problem. Any other tobias- clusters that are left after
http://35.229.40.30:8080/ goes unresponsive will have failed the run,
too. Just in case either you or @nvanbenschoten
<https://github.com/nvanbenschoten> want to dig later today.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#43110?email_source=notifications&email_token=AAC4C4PW23NEEBMV5OB73M3Q7LTDZA5CNFSM4JZJOUL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ2YEGA#issuecomment-578126360>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC4C4LHEYT5D3NKWCUV7D3Q7LTDZANCNFSM4JZJOULQ>
.
|
(roachtest).tpcc/mixed-headroom/n5cpu16 failed on master@3c408a47707a15d4b5c92031c4eafcfa643d307c:
More
Artifacts: /tpcc/mixed-headroom/n5cpu16 See this test on roachdash |
I'm rolling back the main commit from #42969. And I can confirm that on one of the leftover tobias clusters, TPCC check 3.3.2.1 indeed is failing... |
44350: storage: revert "storage: rationalize server-side refreshes and fix bugs" r=andreimatei a=andreimatei This reverts commit 1edb0d5. Revert the main commit from #42969 (storage: rationalize server-side refreshes and fix bugs). It seems to be causing consistency problems, as seen in #43110. Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
#44350 rolled back the main commit from #42969. Surprisingly, that does not seem to fix it (which is good news, I guess...). #44381 reverts the rest. This does fix it. The good news is that it repros with 4cpu clusters instead of the tests's 16cpu clusters. It's interesting that this test is a mixed-version test. I've verified that it does not seem to fail when all nodes are at HEAD. One of the two failure modes is with duplicate key errors on newOrder. The value for the PK of the orders is computed with
This query executes as a scan followed by a put. That's as far as I've gotten. I suspect 0417ab0. More later. |
44381: storage: revert remaining bits of 42969 r=andreimatei a=andreimatei Revert everything from #42969 that wasn't reverted by #44350. Even after the partial revert in #44350, it appears the bug causing TPCC to fail (#43110) is still there. Release note: None Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
I've found it. It's about a 20.1 migrations which removes the use of the currently-named |
(roachtest).tpcc/mixed-headroom/n5cpu16 failed on master@752dea867f3aeb142e98c22f8d320ce19041aa8d:
More
Artifacts: /tpcc/mixed-headroom/n5cpu16
See this test on roachdash |
No artifact because of the awkward timeout mode, but I think we can chalk this up to #45830 |
@andreimatei did we fix this yet? |
(roachtest).tpcc/mixed-headroom/n5cpu16 failed on master@c473f40078994551cebcbe00fdbf1fa388957658:
More
Artifacts: /tpcc/mixed-headroom/n5cpu16
See this test on roachdash |
Here's another one to close once you've verified your fix. |
Yeah, that was a fixed a while ago. |
I'm kicking off a series of these tests on |
10/10 passing. This looks fixed. |
(roachtest).tpcc/mixed-headroom/n5cpu16 failed on provisional_201912102236_v20.1.0-alpha20191211@62640b24b4b12535600e670023e61f7b1c7309ce:
details
Artifacts: /tpcc/mixed-headroom/n5cpu16
powered by pkg/cmd/internal/issues
The text was updated successfully, but these errors were encountered: