Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: dump-backwards-compatibility failed #53514

Closed
cockroach-teamcity opened this issue Aug 26, 2020 · 1 comment · Fixed by #53579
Closed

roachtest: dump-backwards-compatibility failed #53514

cockroach-teamcity opened this issue Aug 26, 2020 · 1 comment · Fixed by #53579
Assignees
Labels
C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Milestone

Comments

@cockroach-teamcity
Copy link
Member

(roachtest).dump-backwards-compatibility failed on provisional_202008261913_v20.2.0-beta.1@eaa939ce6548a54a23970814ff00f30ad87680ac:

The test failed on branch=provisional_202008261913_v20.2.0-beta.1, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/dump-backwards-compatibility/run_1
	test.go:267,dump.go:71,versionupgrade.go:186,dump.go:45,dump.go:87,test_runner.go:754: expected CREATE TABLE t (
			x INT8 NULL,
			y INT8 NULL,
			FAMILY "primary" (x, y, rowid)
		);
		
		INSERT INTO public.t (x, y) VALUES
			(1, 1),
			(2, 2);, but found Flag --insecure has been deprecated, it will be removed in a subsequent release.
		For details, see: https://go.crdb.dev/issue/53404
		CREATE TABLE t (
			x INT8 NULL,
			y INT8 NULL,
			FAMILY "primary" (x, y, rowid)
		);
		
		INSERT INTO public.t (x, y) VALUES
			(1, 1),
			(2, 2);

More

Artifacts: /dump-backwards-compatibility
Related:

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity cockroach-teamcity added branch-provisional_202008261913_v20.2.0-beta.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Aug 26, 2020
@cockroach-teamcity cockroach-teamcity added this to the 20.2 milestone Aug 26, 2020
@adityamaru adityamaru self-assigned this Aug 27, 2020
@pbardea
Copy link
Contributor

pbardea commented Aug 27, 2020

Note this is the same as #53460, so the fix can close both.

craig bot pushed a commit that referenced this issue Aug 31, 2020
53579: roachtest: fix dump-backwards-compatability roachtest r=pbardea a=adityamaru

Elide the --insecure flag deprecation message until roachtest
is taught to run on a secure cluster.

Fixes: #53514, #53460

Release justification: non-production code changes

Co-authored-by: Aditya Maru <adityamaru@gmail.com>
@craig craig bot closed this as completed in 9e3fcde Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants