-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: embed zone configs within descriptors objects #66396
Comments
Hi @irfansharif, please add a C-ategory label to your issue. Check out the label system docs. While you're here, please consider adding an A- label to help keep our repository tidy. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
@irfansharif curious why this issue was labeled MT. Can you please comment? |
No good reason, this came out of the multi-tenant zone configs work so likely applied the label too liberally. |
This isn't something we have to do, and indeed there is no pressing reason to do it right now. It would be cleaner to associate this state more directly with the descriptors given we cache and write it in a correlated way. In reality, we'll probably more towards this when implementing transactional schema change. When we need to more generally encapsulate under a unified concept, this would be an important step. |
I don't think we're going to do this. There exist other things-that-join-on-descriptors like comments, and we're going to be content to just have the descriptors collection mediate access to them. |
Part of #66348. This will let us deprecate
system.zones
, and later provide the optimizer the cache of zone configs it needs for locality-aware planning. We'll also use embedded zone config to generate span configs for KV (#66391). We'll need to be careful around ensuring compatibility with existing backups here.For the migration, we can first introduce a cluster version v21.1-A, which when rolled into, will disallow setting new zone configs (we'll later re-allow it after v21.1-B). We'll then recurse through all descriptors, and for each one copy over the corresponding zone config from
system.zones
into it.Jira issue: CRDB-8024
The text was updated successfully, but these errors were encountered: