Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv/kvserver: TestMergeQueue failed #66942

Closed
cockroach-teamcity opened this issue Jun 28, 2021 · 2 comments · Fixed by #68808
Closed

kv/kvserver: TestMergeQueue failed #66942

cockroach-teamcity opened this issue Jun 28, 2021 · 2 comments · Fixed by #68808
Assignees
@nvanbenschoten
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. skipped-test

Comments

@cockroach-teamcity
Copy link
Member

kv/kvserver.TestMergeQueue failed with artifacts on master @ 52f87b5a495e33704b82b93729bd61fb76d5fecc:

=== RUN   TestMergeQueue
    test_log_scope.go:73: test logs captured to: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestMergeQueue045735340
    test_log_scope.go:74: use -show-logs to present logs inline
=== CONT  TestMergeQueue
    client_merge_test.go:4402: -- test log scope end --
test logs left over in: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestMergeQueue045735340
--- FAIL: TestMergeQueue (7.97s)
=== RUN   TestMergeQueue/sticky-bit-expiration
    client_merge_test.go:4395: ranges unexpectedly merged
    --- FAIL: TestMergeQueue/sticky-bit-expiration (0.54s)
Reproduce

To reproduce, try: 

make stressrace TESTS=TestMergeQueue PKG=./pkg/kv/kvserver TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

Parameters in this failure:

  • GOFLAGS=-json

Internal log 

benesch marked as alumn{us/a}; resolving to nvanbenschoten instead

/cc @cockroachdb/kv nvanbenschoten

This test on roachdash | Improve this report!
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Jun 28, 2021
@irfansharif
Copy link
Contributor

Repros reliably according to Rafa: #64867. De-duping in favor of this issue.

@irfansharif irfansharif mentioned this issue Jun 30, 2021
Closed
@irfansharif irfansharif mentioned this issue Jun 30, 2021
Merged
irfansharif added a commit to irfansharif/cockroach that referenced this issue Jun 30, 2021
@irfansharif
ccl,kv: skip a few flakey tests/sub-tests
3993a69 
Relevant test failure issues: cockroachdb#66991, cockroachdb#67034, cockroachdb#66942, cockroachdb#66480, cockroachdb#64313.

Release note: None
craig bot pushed a commit that referenced this issue Jun 30, 2021
@irfansharif
Merge #67082
25f3761 
67082: ccl,kv: skip a few flakey tests/sub-tests r=irfansharif a=irfansharif

Relevant test failure issues: #66991, #67034, #66942, #66480, #64313.

Release note: None

Co-authored-by: irfan sharif <irfanmahmoudsharif@gmail.com>
@knz
Copy link
Contributor

knz commented Aug 12, 2021

still repros

@nvanbenschoten nvanbenschoten mentioned this issue Aug 12, 2021
Merged
@nvanbenschoten nvanbenschoten self-assigned this Aug 12, 2021
@nvanbenschoten nvanbenschoten mentioned this issue Aug 12, 2021
Closed
craig bot pushed a commit that referenced this issue Aug 13, 2021
@nvanbenschoten
Merge #68808
7018384 
68808: kv: deflake and unskip TestMergeQueue/sticky-bit-expiration r=nvanbenschoten a=nvanbenschoten

Fixes #66942.

This was broken by 78078b8, which switched the test from using a `ManualClock` to using a `HybridManualClock`.

Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
@craig craig bot closed this as completed in b333424 Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvanbenschoten nvanbenschoten

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. skipped-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kv: deflake and unskip TestMergeQueue/sticky-bit-expiration nvanbenschoten/cockroach
4 participants
@knz @nvanbenschoten @irfansharif @cockroach-teamcity