Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: pgjdbc failed #71564

Closed
cockroach-teamcity opened this issue Oct 14, 2021 · 7 comments · Fixed by #71722
Closed

roachtest: pgjdbc failed #71564

cockroach-teamcity opened this issue Oct 14, 2021 · 7 comments · Fixed by #71722
Assignees
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot.

Comments

@cockroach-teamcity
Copy link
Member

roachtest.pgjdbc failed with artifacts on master @ 24d632ccabb7d03b887d399e705f7e1b6b9f7435:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/pgjdbc/run_1
	orm_helpers.go:245,orm_helpers.go:171,java_helpers.go:220,pgjdbc.go:185,pgjdbc.go:197,test_runner.go:777: 
		Tests run on Cockroach v21.2.0-alpha.00000000-4994-g24d632ccab
		Tests run against pgjdbc REL42.2.19
		5298 Total Tests Run
		4473 tests passed
		825 tests failed
		60 tests skipped
		185 tests ignored
		4 tests passed unexpectedly
		2 tests failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- PASS: org.postgresql.test.jdbc42.GetObject310Test.testGetLocalTimeInvalidType[binary = REGULAR] - https://github.com/cockroachdb/cockroach/issues/26097 (unexpected)
		--- PASS: org.postgresql.test.jdbc42.GetObject310Test.testGetLocalTimeInvalidType[binary = FORCE] - https://github.com/cockroachdb/cockroach/issues/26097 (unexpected)
		--- PASS: org.postgresql.test.jdbc2.PGTimeTest.testTimeInsertAndSelect - https://github.com/cockroachdb/cockroach/issues/41775 (unexpected)
		--- FAIL: org.postgresql.test.jdbc2.ArrayTest.testSetNullArrays[binary = FORCE] - unknown (unexpected)
		--- FAIL: org.postgresql.test.jdbc2.ArrayTest.testSetNullArrays[binary = REGULAR] - unknown (unexpected)
		--- PASS: org.postgresql.test.jdbc2.PGTimestampTest.testTimeInsertAndSelect - https://github.com/cockroachdb/cockroach/issues/41775 (unexpected)
		For a full summary look at the pgjdbc artifacts 
		
		An updated blocklist (pgjdbcBlockList21_2) is available in the artifacts' pgjdbc log
Reproduce

See: roachtest README

/cc @cockroachdb/sql-experience

This test on roachdash | Improve this report!

@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Oct 14, 2021
@rafiss
Copy link
Collaborator

rafiss commented Oct 14, 2021

random guess, but probably the new passes are because of support for assignment casts. #70722

the testSetNullArrays failure is new, and is also because of assignment casts. cc @mgartner in case an explanation jumps out at you.

�[0;31;1mFAILURE�[0m   0.1sec, org.postgresql.test.jdbc2.�[0;1mArrayTest�[0m > �[0;1mtestSetNullArrays�[0m[binary = REGULAR]
    org.postgresql.util.PSQLException: ERROR: invalid assignment cast: unknown -> int[]
        at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2553)
        at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:2285)
        at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:323)
        at org.postgresql.jdbc.PgStatement.executeInternal(PgStatement.java:481)
        at org.postgresql.jdbc.PgStatement.execute(PgStatement.java:401)
        at org.postgresql.jdbc.PgPreparedStatement.executeWithFlags(PgPreparedStatement.java:164)
        at org.postgresql.jdbc.PgPreparedStatement.executeUpdate(PgPreparedStatement.java:130)
        �[0;1mat org.postgresql.test.jdbc2.ArrayTest.testSetNullArrays(ArrayTest.java:349)

Test at https://github.com/pgjdbc/pgjdbc/blob/207ce36ec2c5cce30c454afa3e51f39bbe5bd26b/pgjdbc/src/test/java/org/postgresql/test/jdbc2/ArrayTest.java#L340

  @Test
  public void testSetNullArrays() throws SQLException {
    PreparedStatement pstmt = conn.prepareStatement("INSERT INTO arrtest VALUES (?,?,?)");

    final PGConnection arraySupport = conn.unwrap(PGConnection.class);

    pstmt.setArray(1, arraySupport.createArrayOf("int4", null));
    pstmt.setObject(2, conn.createArrayOf("float8", null));
    pstmt.setObject(3, arraySupport.createArrayOf("varchar", null));

    pstmt.executeUpdate();
    pstmt.close();

    Statement stmt = conn.createStatement();
    ResultSet rs = stmt.executeQuery("SELECT intarr, decarr, strarr FROM arrtest");
    Assert.assertTrue(rs.next());

    Array arr = rs.getArray(1);
    Assert.assertNull(arr);

    arr = rs.getArray(2);
    Assert.assertNull(arr);

    arr = rs.getArray(3);
    Assert.assertNull(arr);

    rs.close();
  }

@rafiss rafiss removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Oct 14, 2021
@mgartner
Copy link
Collaborator

Thanks for pointing this out. I expected some fallout from that change. I'll take a look.

@cockroach-teamcity
Copy link
Member Author

roachtest.pgjdbc failed with artifacts on master @ 0984f873c6170ab34afe6fee4661fc5f76ac0dee:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/pgjdbc/run_1
	orm_helpers.go:245,orm_helpers.go:171,java_helpers.go:220,pgjdbc.go:185,pgjdbc.go:197,test_runner.go:777: 
		Tests run on Cockroach v21.2.0-alpha.00000000-5058-g0984f873c6-dirty
		Tests run against pgjdbc REL42.2.19
		5298 Total Tests Run
		4474 tests passed
		824 tests failed
		60 tests skipped
		185 tests ignored
		5 tests passed unexpectedly
		2 tests failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: org.postgresql.test.jdbc2.ArrayTest.testSetNullArrays[binary = FORCE] - unknown (unexpected)
		--- FAIL: org.postgresql.test.jdbc2.ArrayTest.testSetNullArrays[binary = REGULAR] - unknown (unexpected)
		--- PASS: org.postgresql.test.jdbc2.PGTimeTest.testTimeInsertAndSelect - https://github.com/cockroachdb/cockroach/issues/41775 (unexpected)
		--- PASS: org.postgresql.test.jdbc42.GetObject310Test.testGetLocalTimeInvalidType[binary = FORCE] - https://github.com/cockroachdb/cockroach/issues/26097 (unexpected)
		--- PASS: org.postgresql.test.jdbc2.SearchPathLookupTest.testSearchPathHiddenLookup -  (unexpected)
		--- PASS: org.postgresql.test.jdbc42.GetObject310Test.testGetLocalTimeInvalidType[binary = REGULAR] - https://github.com/cockroachdb/cockroach/issues/26097 (unexpected)
		--- PASS: org.postgresql.test.jdbc2.PGTimestampTest.testTimeInsertAndSelect - https://github.com/cockroachdb/cockroach/issues/41775 (unexpected)
		For a full summary look at the pgjdbc artifacts 
		
		An updated blocklist (pgjdbcBlockList21_2) is available in the artifacts' pgjdbc log
Reproduce

See: roachtest README

/cc @cockroachdb/sql-experience

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.pgjdbc failed with artifacts on master @ b3af96b0686773c78325d2b8b0623a8fcd3e9bf2:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/pgjdbc/run_1
	orm_helpers.go:245,orm_helpers.go:171,java_helpers.go:220,pgjdbc.go:185,pgjdbc.go:197,test_runner.go:777: 
		Tests run on Cockroach v21.2.0-alpha.00000000-5076-gb3af96b068
		Tests run against pgjdbc REL42.2.19
		5298 Total Tests Run
		4474 tests passed
		824 tests failed
		60 tests skipped
		185 tests ignored
		5 tests passed unexpectedly
		2 tests failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: org.postgresql.test.jdbc2.ArrayTest.testSetNullArrays[binary = REGULAR] - unknown (unexpected)
		--- PASS: org.postgresql.test.jdbc42.GetObject310Test.testGetLocalTimeInvalidType[binary = REGULAR] - https://github.com/cockroachdb/cockroach/issues/26097 (unexpected)
		--- PASS: org.postgresql.test.jdbc2.SearchPathLookupTest.testSearchPathHiddenLookup -  (unexpected)
		--- PASS: org.postgresql.test.jdbc42.GetObject310Test.testGetLocalTimeInvalidType[binary = FORCE] - https://github.com/cockroachdb/cockroach/issues/26097 (unexpected)
		--- PASS: org.postgresql.test.jdbc2.PGTimeTest.testTimeInsertAndSelect - https://github.com/cockroachdb/cockroach/issues/41775 (unexpected)
		--- FAIL: org.postgresql.test.jdbc2.ArrayTest.testSetNullArrays[binary = FORCE] - unknown (unexpected)
		--- PASS: org.postgresql.test.jdbc2.PGTimestampTest.testTimeInsertAndSelect - https://github.com/cockroachdb/cockroach/issues/41775 (unexpected)
		For a full summary look at the pgjdbc artifacts 
		
		An updated blocklist (pgjdbcBlockList21_2) is available in the artifacts' pgjdbc log
Reproduce

See: roachtest README

/cc @cockroachdb/sql-experience

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.pgjdbc failed with artifacts on master @ 5d972a683c531326bc0af403c6d3373d3f4b2267:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/pgjdbc/run_1
	orm_helpers.go:245,orm_helpers.go:171,java_helpers.go:220,pgjdbc.go:185,pgjdbc.go:197,test_runner.go:777: 
		Tests run on Cockroach v21.2.0-alpha.00000000-5078-g5d972a683c
		Tests run against pgjdbc REL42.2.19
		5298 Total Tests Run
		4474 tests passed
		824 tests failed
		60 tests skipped
		185 tests ignored
		5 tests passed unexpectedly
		2 tests failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- PASS: org.postgresql.test.jdbc2.SearchPathLookupTest.testSearchPathHiddenLookup -  (unexpected)
		--- PASS: org.postgresql.test.jdbc42.GetObject310Test.testGetLocalTimeInvalidType[binary = FORCE] - https://github.com/cockroachdb/cockroach/issues/26097 (unexpected)
		--- PASS: org.postgresql.test.jdbc2.PGTimeTest.testTimeInsertAndSelect - https://github.com/cockroachdb/cockroach/issues/41775 (unexpected)
		--- FAIL: org.postgresql.test.jdbc2.ArrayTest.testSetNullArrays[binary = REGULAR] - unknown (unexpected)
		--- PASS: org.postgresql.test.jdbc42.GetObject310Test.testGetLocalTimeInvalidType[binary = REGULAR] - https://github.com/cockroachdb/cockroach/issues/26097 (unexpected)
		--- PASS: org.postgresql.test.jdbc2.PGTimestampTest.testTimeInsertAndSelect - https://github.com/cockroachdb/cockroach/issues/41775 (unexpected)
		--- FAIL: org.postgresql.test.jdbc2.ArrayTest.testSetNullArrays[binary = FORCE] - unknown (unexpected)
		For a full summary look at the pgjdbc artifacts 
		
		An updated blocklist (pgjdbcBlockList21_2) is available in the artifacts' pgjdbc log
Reproduce

See: roachtest README

/cc @cockroachdb/sql-experience

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.pgjdbc failed with artifacts on master @ 649a8ca38cdc0883dd7a7811b189ea53af19f644:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/pgjdbc/run_1
	orm_helpers.go:245,orm_helpers.go:171,java_helpers.go:220,pgjdbc.go:185,pgjdbc.go:197,test_runner.go:777: 
		Tests run on Cockroach v22.1.0-alpha.00000000-471-g649a8ca38c
		Tests run against pgjdbc REL42.2.19
		5298 Total Tests Run
		4474 tests passed
		824 tests failed
		60 tests skipped
		185 tests ignored
		5 tests passed unexpectedly
		2 tests failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- PASS: org.postgresql.test.jdbc42.GetObject310Test.testGetLocalTimeInvalidType[binary = FORCE] - https://github.com/cockroachdb/cockroach/issues/26097 (unexpected)
		--- PASS: org.postgresql.test.jdbc2.PGTimestampTest.testTimeInsertAndSelect - https://github.com/cockroachdb/cockroach/issues/41775 (unexpected)
		--- PASS: org.postgresql.test.jdbc2.PGTimeTest.testTimeInsertAndSelect - https://github.com/cockroachdb/cockroach/issues/41775 (unexpected)
		--- FAIL: org.postgresql.test.jdbc2.ArrayTest.testSetNullArrays[binary = REGULAR] - unknown (unexpected)
		--- PASS: org.postgresql.test.jdbc42.GetObject310Test.testGetLocalTimeInvalidType[binary = REGULAR] - https://github.com/cockroachdb/cockroach/issues/26097 (unexpected)
		--- PASS: org.postgresql.test.jdbc2.SearchPathLookupTest.testSearchPathHiddenLookup -  (unexpected)
		--- FAIL: org.postgresql.test.jdbc2.ArrayTest.testSetNullArrays[binary = FORCE] - unknown (unexpected)
		For a full summary look at the pgjdbc artifacts 
		
		An updated blocklist (pgjdbcBlockList22_1) is available in the artifacts' pgjdbc log
Reproduce

See: roachtest README

/cc @cockroachdb/sql-experience

This test on roachdash | Improve this report!

@rafiss
Copy link
Collaborator

rafiss commented Oct 19, 2021

created #71714 to track the casting change, so I'll now update the expected failures for this test.

@rafiss rafiss self-assigned this Oct 19, 2021
@craig craig bot closed this as completed in 5c33d12 Oct 20, 2021
@craig craig bot closed this as completed in #71722 Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants