Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv/kvserver: TestReplicateQueueUpAndDownReplicateNonVoters failed #74995

Closed
cockroach-teamcity opened this issue Jan 18, 2022 · 1 comment · Fixed by #75072
Closed

kv/kvserver: TestReplicateQueueUpAndDownReplicateNonVoters failed #74995

cockroach-teamcity opened this issue Jan 18, 2022 · 1 comment · Fixed by #75072
Assignees
@arulajmani
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.

Comments

@cockroach-teamcity
Copy link
Member

kv/kvserver.TestReplicateQueueUpAndDownReplicateNonVoters failed with artifacts on master @ 365b4da8bd02c06ee59d2130a56dec74ffc9ce21:

=== RUN   TestReplicateQueueUpAndDownReplicateNonVoters
    test_log_scope.go:79: test logs captured to: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestReplicateQueueUpAndDownReplicateNonVoters2210080764
    test_log_scope.go:80: use -show-logs to present logs inline
    replicate_queue_test.go:359: condition failed to evaluate within 45s: expected upreplication to 2 non-voters; found 0
        goroutine 96551138 [running]:
        runtime/debug.Stack()
        	/usr/local/go/src/runtime/debug/stack.go:24 +0x65
        github.com/cockroachdb/cockroach/pkg/testutils.SucceedsWithin({0x538caf8, 0xc01a2b4d00}, 0x0, 0xc016d840c0)
        	/go/src/github.com/cockroachdb/cockroach/pkg/testutils/soon.go:60 +0x5f
        github.com/cockroachdb/cockroach/pkg/testutils.SucceedsSoon({0x538caf8, 0xc01a2b4d00}, 0x0)
        	/go/src/github.com/cockroachdb/cockroach/pkg/testutils/soon.go:41 +0x4a
        github.com/cockroachdb/cockroach/pkg/kv/kvserver_test.TestReplicateQueueUpAndDownReplicateNonVoters(0xc01a2b4d00)
        	/go/src/github.com/cockroachdb/cockroach/pkg/kv/kvserver/replicate_queue_test.go:359 +0x4c5
        testing.tRunner(0xc01a2b4d00, 0x43da390)
        	/usr/local/go/src/testing/testing.go:1259 +0x102
        created by testing.(*T).Run
        	/usr/local/go/src/testing/testing.go:1306 +0x35a
    panic.go:642: -- test log scope end --
test logs left over in: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestReplicateQueueUpAndDownReplicateNonVoters2210080764
--- FAIL: TestReplicateQueueUpAndDownReplicateNonVoters (46.93s)
Help

See also: How To Investigate a Go Test Failure (internal)
Parameters in this failure:

  • TAGS=deadlock

  • GOFLAGS=-parallel=2

/cc @cockroachdb/kv

This test on roachdash | Improve this report!
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Jan 18, 2022
@irfansharif
Copy link
Contributor

Possible fallout from #73876; @arulajmani's going to confirm if so.

@arulajmani arulajmani mentioned this issue Jan 18, 2022
Merged
craig bot pushed a commit that referenced this issue Jan 18, 2022
@cucaroach @arulajmani
Merge #75069 #75072
3b9a957 
75069: sql: re-fix enum hydration in distsql expression evaluation r=cucaroach a=cucaroach

Fixes: #74442

This previous fix for this issue didn't backport cleanly and this
amends the fix to inline HydrateSlice to avoid type dynamic type
checking.

Release note: None


75072: kvserver: deflake TestReplicateQueue{UpAndDownReplicateNonVoters,Shou… r=arulajmani a=arulajmani

…ldQueueNonVoter}

These tests altered `RANGE DEFAULT` and expect the changes to apply to
the scratch range. This is gated behind a testing knob with the move to
the span configurations infrastructure. This patch adds the testing
knob.

Closes #74995

Release note: None

Co-authored-by: Tommy Reilly <treilly@cockroachlabs.com>
Co-authored-by: arulajmani <arulajmani@gmail.com>
@craig craig bot closed this as completed in 1725b53 Jan 18, 2022
gtr pushed a commit that referenced this issue Jan 18, 2022
@arulajmani
kvserver: deflake TestReplicateQueue{UpAndDownReplicateNonVoters,Shou…
98195e6 
…ldQueueNonVoter}

These tests altered `RANGE DEFAULT` and expect the changes to apply to
the scratch range. This is gated behind a testing knob with the move to
the span configurations infrastructure. This patch adds the testing
knob.

Closes #74995

Release note: None
@irfansharif irfansharif mentioned this issue Jan 28, 2022
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arulajmani arulajmani

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kvserver: deflake TestReplicateQueue{UpAndDownReplicateNonVoters,Shou… arulajmani/cockroach
3 participants
@arulajmani @irfansharif @cockroach-teamcity