Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

descpb: remove gc_mutations field from table descriptor #75444

Closed
postamar opened this issue Jan 24, 2022 · 0 comments · Fixed by #82417
Closed

descpb: remove gc_mutations field from table descriptor #75444

postamar opened this issue Jan 24, 2022 · 0 comments · Fixed by #82417
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@postamar
Copy link
Contributor

postamar commented Jan 24, 2022 •
edited by cockroach-jira-scripts
Loading

Follow-up work from #75280

This field isn't used in any meaningful way, and will certainly be safe to remove once 22.1 is out.

Jira issue: CRDB-12674
@postamar postamar added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Jan 24, 2022
@blathers-crl blathers-crl bot added the T-sql-schema-deprecated Use T-sql-foundations instead label Jan 24, 2022
@jasonmchan jasonmchan mentioned this issue Jun 3, 2022
Merged
craig bot pushed a commit that referenced this issue Jun 3, 2022
@sjbarag @erikgrinaker
Merge #81952 #82399 #82417
f0892ea 
81952: db-console: enable type-checking during linting r=rickystewart,laurenbarker a=sjbarag

TypeScript type-checking was previously not configured for db-console
due to dependency version mismatches [1]. Now that those have been
resolved, configure type-checking in the
//pkg/ui/workspaces/db-console:lint test suite.

[1] #81409
fixes #81203

Release note: None

82399: storage: add batch variant of `BenchmarkMVCCGet_Pebble` r=jbowens a=erikgrinaker

Release note: None

82417: sql: remove gc_mutations field from table descriptor r=chengxiong-ruan a=jasonmchan

This field is deprecated, and we no longer populate it. This commit
removes the field entirely and removes logic that deletes the entries of
the field.

Fixes #75444

Release note: None

Co-authored-by: Sean Barag <barag@cockroachlabs.com>
Co-authored-by: Erik Grinaker <grinaker@cockroachlabs.com>
Co-authored-by: Jason Chan <jason.chan@cockroachlabs.com>
@craig craig bot closed this as completed in 4440bf6 Jun 3, 2022
@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: remove gc_mutations field from table descriptor jasonmchan/cockroach
1 participant
@postamar