Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: schemachange/mixed-versions failed #87768

Closed
cockroach-teamcity opened this issue Sep 10, 2022 · 1 comment · Fixed by #88475
Closed

roachtest: schemachange/mixed-versions failed #87768

cockroach-teamcity opened this issue Sep 10, 2022 · 1 comment · Fixed by #88475
Assignees
@fqazi
Labels
branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 C-test-failure Broken test (automatically or manually discovered). GA-blocker O-roachtest O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Milestone
22.2

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Sep 10, 2022 •
edited by cockroach-jira-scripts
Loading

roachtest.schemachange/mixed-versions failed with artifacts on release-22.2 @ 1bfe9bcda653f55ed3b4216610433b51b2ef0d8f:

		  |   301.0s       15            0.0            0.0      0.0      0.0      0.0      0.0 txnRbk
		  |   302.0s       15            0.0            0.5      0.0      0.0      0.0      0.0 opOk
		  |   302.0s       15            0.0            0.0      0.0      0.0      0.0      0.0 txnCmtErr
		  |   302.0s       15            0.0            0.1      0.0      0.0      0.0      0.0 txnOk
		  |   302.0s       15            0.0            0.0      0.0      0.0      0.0      0.0 txnRbk
		  |   303.0s       15            0.0            0.5      0.0      0.0      0.0      0.0 opOk
		  |   303.0s       15            0.0            0.0      0.0      0.0      0.0      0.0 txnCmtErr
		  |   303.0s       15            0.0            0.1      0.0      0.0      0.0      0.0 txnOk
		  |   303.0s       15            0.0            0.0      0.0      0.0      0.0      0.0 txnRbk
		  |   304.0s       15            0.0            0.5      0.0      0.0      0.0      0.0 opOk
		  |   304.0s       15            0.0            0.0      0.0      0.0      0.0      0.0 txnCmtErr
		  |   304.0s       15            0.0            0.1      0.0      0.0      0.0      0.0 txnOk
		  |   304.0s       15            0.0            0.0      0.0      0.0      0.0      0.0 txnRbk
		  |   305.0s       15            0.0            0.5      0.0      0.0      0.0      0.0 opOk
		  |   305.0s       15            0.0            0.0      0.0      0.0      0.0      0.0 txnCmtErr
		  |   305.0s       15            0.0            0.1      0.0      0.0      0.0      0.0 txnOk
		  |   305.0s       15            0.0            0.0      0.0      0.0      0.0      0.0 txnRbk
		  |   306.0s       15            0.0            0.5      0.0      0.0      0.0      0.0 opOk
		  |   306.0s       15            0.0            0.0      0.0      0.0      0.0      0.0 txnCmtErr
		  | _elapsed___errors__ops/sec(inst)___ops/sec(cum)__p50(ms)__p95(ms)__p99(ms)_pMax(ms)
		  |   306.0s       15            0.0            0.1      0.0      0.0      0.0      0.0 txnOk
		  |   306.0s       15            0.0            0.0      0.0      0.0      0.0      0.0 txnRbk
		  |   307.0s       15            0.0            0.5      0.0      0.0      0.0      0.0 opOk
		  |   307.0s       15            0.0            0.0      0.0      0.0      0.0      0.0 txnCmtErr
		  |   307.0s       15            0.0            0.1      0.0      0.0      0.0      0.0 txnOk
		  |   307.0s       15            0.0            0.0      0.0      0.0      0.0      0.0 txnRbk
		  |   308.0s       15            0.0            0.5      0.0      0.0      0.0      0.0 opOk
		  |   308.0s       15            0.0            0.0      0.0      0.0      0.0      0.0 txnCmtErr
		  |   308.0s       15            0.0            0.1      0.0      0.0      0.0      0.0 txnOk
		  |   308.0s       15            0.0            0.0      0.0      0.0      0.0      0.0 txnRbk
		  |   309.0s       15            0.0            0.5      0.0      0.0      0.0      0.0 opOk
		  |   309.0s       15            0.0            0.0      0.0      0.0      0.0      0.0 txnCmtErr
		  |   309.0s       15            0.0            0.1      0.0      0.0      0.0      0.0 txnOk
		  |   309.0s       15            0.0            0.0      0.0      0.0      0.0      0.0 txnRbk
		  |   310.0s       15            0.0            0.5      0.0      0.0      0.0      0.0 opOk
		  |   310.0s       15            0.0            0.0      0.0      0.0      0.0      0.0 txnCmtErr
		  |   310.0s       15            0.0            0.1      0.0      0.0      0.0      0.0 txnOk
		  |   310.0s       15            0.0            0.0      0.0      0.0      0.0      0.0 txnRbk
		  |   311.0s       15            0.0            0.5      0.0      0.0      0.0      0.0 opOk
		  |   311.0s       15            0.0            0.0      0.0      0.0      0.0      0.0 txnCmtErr
		  | _elapsed___errors__ops/sec(inst)___ops/sec(cum)__p50(ms)__p95(ms)__p99(ms)_pMax(ms)
		  |   311.0s       15            0.0            0.1      0.0      0.0      0.0      0.0 txnOk
		  |   311.0s       15            0.0            0.0      0.0      0.0      0.0      0.0 txnRbk
		Wraps: (4) SSH_PROBLEM
		Wraps: (5) Node 3. Command with error:
		  | ``````
		  | ./workload run schemachange --verbose=1 --tolerate-errors=true --max-ops 100 --concurrency 5 {pgurl:1-4}
		  | ``````
		Wraps: (6) exit status 255
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *cluster.WithCommandDetails (4) errors.SSH (5) *hintdetail.withDetail (6) *exec.ExitError

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

/cc @cockroachdb/sql-schema

This test on roachdash | Improve this report!

Jira issue: CRDB-19521
@cockroach-teamcity cockroach-teamcity added branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Sep 10, 2022
@cockroach-teamcity cockroach-teamcity added this to the 22.2 milestone Sep 10, 2022
@blathers-crl blathers-crl bot added the T-sql-schema-deprecated Use T-sql-foundations instead label Sep 10, 2022
@ajwerner ajwerner added GA-blocker and removed release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Sep 12, 2022
@ajwerner
Copy link
Contributor

I think this might be fixed by #87706 (comment). @fqazi can you take a look if you find time?

@cockroach-teamcity cockroach-teamcity mentioned this issue Sep 22, 2022
Closed
@fqazi fqazi mentioned this issue Sep 22, 2022
Merged
craig bot pushed a commit that referenced this issue Sep 22, 2022
@Xiang-Gu @nvanbenschoten
@ajwerner @fqazi @msbutler @knz
Merge #87808 #88082 #88459 #88468 #88475 #88476 #88478
d390148 
87808: norm: do not fold floor division with unit denominator r=msirek a=msirek

Fixes #87605

The floor division operator `//` is like division but drops the
fractional portion of the result. Normalization rule FoldDivOne
rewrites `(column // 1)` as `(column)` which is incorrect if the
data in `column` has fractional digits, as those digits should be
dropped.

The solution is to only fold `(column // 1)` when `column` is one of
the integer types.

Release note (bug fix): This patch fixes incorrect results from
the floor division operator, `//`, when the numerator is non-constant
and the denominator is the constant 1.

88082: *: audit operation names in new schema changer r=Xiang-Gu a=Xiang-Gu

This PR made non-functional changes related to new schema changer ops:
1. Rename all status changing operation on Index and Column to comform
to the pattern: `Make[StatusA][Index/Column][StatusB]`

2. Rename a few constant/field/function names to be consistent with the
principle of "being explicit":
  2.1. Rename operation name `XxxGcXxx` to `XxxGCXxx`;
  2.2. Rename field name in operations `DescID` to `DescriptorID`;
  2.3. Rename descpb.DELETE_AND_WRITE_ONLY to descpb.WRITE_ONLY;
  2.4. Rename sql.RunningStatusDeleteAndWriteOnly to sql.RunningStatusWriteOnly

3. Seveal comments enhencement

4. Rename `DELETE_AND_WRITE_ONLY` to `WRITE_ONLY` in some files under
docs/.

Fixes #84583

Release note: None

88459: kv: fix spelling of "interceptor" in file name r=nvanbenschoten a=nvanbenschoten

All other file names and code objects have the correct spelling.

Release justification: None.

Release note: None.

88468: kvserver/batcheval: ignore UseRangeTombstonesForPointDeletes knob sometimes r=ajwerner a=ajwerner

We want to ignore the point deletion knob for cases where we're deleting data from system tables watched by rangefeeds. Not doing so can lead to missed updates. This is particularly critical for cluster settings.

Fixes #87575
Fixes #87479
Fixes #88202

Release note: None

88475: workload/schemachange/mixed-version: avoid index visibility r=fqazi a=fqazi

Fixes: #87768

Previously, we were generating statements with invisible indexes in mixed version environments, which could lead to statements generated not supported on older versions. To address this, this patch will prevent the generation of create table/ create index statements with invisible indexes.

Release note: None

88476: multitenant: add TestTenants() helper to TestServer r=ajstorm a=msbutler

This patch adds a helper method for accessing information about the tenant(s) that were probabilistically created with the TestServer.

Release note: None

88478: cli/sql: increase maxHistEntries r=ajwerner a=knz

As discussed this morning.

In light of PR #88272, we don't need the limit to be as low as 1000. This commit increases it back to 10000, which is the common default in unix shells and the screen/tmux utilities.


Co-authored-by: Mark Sirek <sirek@cockroachlabs.com>
Co-authored-by: Xiang Gu <xiang@cockroachlabs.com>
Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Co-authored-by: Andrew Werner <awerner32@gmail.com>
Co-authored-by: Faizan Qazi <faizan@cockroachlabs.com>
Co-authored-by: Michael Butler <butler@cockroachlabs.com>
Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
@craig craig bot closed this as completed in 3410251 Sep 22, 2022
fqazi added a commit to fqazi/cockroach that referenced this issue Sep 23, 2022
@fqazi
workload/schemachange/mixed-version: avoid index visibility
d0191d4 
Fixes: cockroachdb#87768

Previously, we were generating statements with invisible indexes in mixed
version environments, which could lead to statements generated not
supported on older versions. To address this, this patch will prevent
the generation of create table/ create index statements with invisible
indexes.

Release note: None
fqazi added a commit to fqazi/cockroach that referenced this issue Oct 11, 2022
@fqazi
workload/schemachange/mixed-version: avoid index visibility
d18da79 
Fixes: cockroachdb#87768

Previously, we were generating statements with invisible indexes in mixed
version environments, which could lead to statements generated not
supported on older versions. To address this, this patch will prevent
the generation of create table/ create index statements with invisible
indexes.

Release note: None
@exalate-issue-sync exalate-issue-sync bot reopened this May 10, 2023
@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 10, 2023
@rafiss rafiss closed this as completed May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fqazi fqazi

Labels
branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 C-test-failure Broken test (automatically or manually discovered). GA-blocker O-roachtest O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
22.2
Development

Successfully merging a pull request may close this issue.

workload/schemachange/mixed-version: avoid index visibility fqazi/cockroach
4 participants
@rafiss @fqazi @ajwerner @cockroach-teamcity