Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pgbuiltins: pg_blocking_pids #91068

Closed
Tracked by #25213
jordanlewis opened this issue Nov 1, 2022 · 2 comments · Fixed by #92253
Closed
Tracked by #25213

pgbuiltins: pg_blocking_pids #91068

jordanlewis opened this issue Nov 1, 2022 · 2 comments · Fixed by #92253
Labels
A-sql-builtins SQL built-in functions and semantics thereof. A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-easy Easy issue to tackle, requires little or no CockroachDB experience E-quick-win Likely to be a quick win for someone experienced. good first issue T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@jordanlewis
Copy link
Member

jordanlewis commented Nov 1, 2022 •
edited by rafiss
Loading

Support pg_blocking_pids builtin. Needed for pgadmin.

https://www.postgresql.org/docs/current/functions-info.html

We can implement this by making it return an empty array, since Cockroach doesn't use PIDs.

Jira issue: CRDB-21093
@jordanlewis jordanlewis added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-sql-pgcompat Semantic compatibility with PostgreSQL A-sql-builtins SQL built-in functions and semantics thereof. labels Nov 1, 2022
@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Nov 1, 2022
@jordanlewis jordanlewis mentioned this issue Nov 2, 2022
Open
25 tasks
@rafiss rafiss added E-easy Easy issue to tackle, requires little or no CockroachDB experience E-quick-win Likely to be a quick win for someone experienced. labels Nov 17, 2022
@girishv-tw
Copy link
Contributor

Hi @jordanlewis ,
I am new to working on cockroach db and was thinking of picking up this issue. Is that ok ?
I have performed an initial analysis on the issue and from that i have arrived at a conclusion that a resolution to the issue would be to , add a builtin for pg_blocking_pids with the return type as an array of integers and the function returning an empty array of integers in this file
Could you help me assert that this is the correct fix ?

@jordanlewis
Copy link
Member Author

Yes, sounds right to me. Thanks!

@girishv-tw girishv-tw mentioned this issue Nov 21, 2022
Merged
@craig craig bot closed this as completed in 14f61c5 Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-sql-builtins SQL built-in functions and semantics thereof. A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-easy Easy issue to tackle, requires little or no CockroachDB experience E-quick-win Likely to be a quick win for someone experienced. good first issue T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql/sem: add support for "pg_blocking_pids" builtin girishv-tw/cockroach
3 participants
@jordanlewis @rafiss @girishv-tw