-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql/sem: add support for "pg_blocking_pids" builtin #92253
Conversation
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. Before a member of our team reviews your PR, I have some potential action items for you:
I have added a few people who may be able to assist in reviewing:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Thanks @girishv-tw! There are some test failures:
Try to update that and resubmit. |
Thank you for updating your pull request. Before a member of our team reviews your PR, I have some potential action items for you:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
@jordanlewis , thanks for pointing that out . I have made the necessary changes and it looks like the tests are passing now. |
Looks good! If you could squash your commits into one, we'll be ready to merge. Thanks. |
This is needed for pgadmin. Release note (sql change): Added support for pg_blocking_pids builtin function. It is hardcoded to return an empty array because CockroachDB has no equivalent concept of PIDs as in Postgres. sql/sem: added field for pg_blocking_pids in builtinOidsBySignature map
19a4c85
to
b19f6b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i took care of squashing the commits. thanks for your contribution!
bors r+
Build succeeded: |
added support pg_blocking_pids builtin. Needed for pgadmin.
Closes #91068
Release note (sql change): add support for pg_blocking_pids builtin function. It is hardcoded to return an empty array because CockroachDB has no equivalent concept of PIDs as in Postgres.