Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/sem: add support for "pg_blocking_pids" builtin #92253

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

girishv-tw
Copy link
Contributor

@girishv-tw girishv-tw commented Nov 21, 2022

added support pg_blocking_pids builtin. Needed for pgadmin.

Closes #91068

Release note (sql change): add support for pg_blocking_pids builtin function. It is hardcoded to return an empty array because CockroachDB has no equivalent concept of PIDs as in Postgres.

@girishv-tw girishv-tw requested a review from a team November 21, 2022 12:42
@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Nov 21, 2022

CLA assistant check
All committers have signed the CLA.

@blathers-crl
Copy link

blathers-crl bot commented Nov 21, 2022

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

Before a member of our team reviews your PR, I have some potential action items for you:

  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

I have added a few people who may be able to assist in reviewing:

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-triaged blathers was able to find an owner labels Nov 21, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jordanlewis
Copy link
Member

Thanks @girishv-tw! There are some test failures:

  panic: Missing an entry for pg_blocking_pids() -> int[] in builtins.BuiltinOidsBySignature. Update the signature there if it's changed, or if it's new, add the following entry:`pg_blocking_pids() -> int[]`: 2045

Try to update that and resubmit.

@blathers-crl
Copy link

blathers-crl bot commented Nov 21, 2022

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

  • We notice you have more than one commit in your PR. We try break logical changes into separate commits, but commits such as "fix typo" or "address review commits" should be squashed into one commit and pushed with --force
  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@girishv-tw
Copy link
Contributor Author

@jordanlewis , thanks for pointing that out . I have made the necessary changes and it looks like the tests are passing now.

@jordanlewis
Copy link
Member

Looks good! If you could squash your commits into one, we'll be ready to merge. Thanks.

This is needed for pgadmin.

Release note (sql change): Added support for pg_blocking_pids builtin function.
It is hardcoded to return an empty array because CockroachDB has no
equivalent concept of PIDs as in Postgres.

sql/sem: added field for pg_blocking_pids in builtinOidsBySignature map
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i took care of squashing the commits. thanks for your contribution!

bors r+

@craig
Copy link
Contributor

craig bot commented Nov 23, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-community Originated from the community X-blathers-triaged blathers was able to find an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pgbuiltins: pg_blocking_pids
4 participants