Commits on Mar 26, 2023

1. sql: block DROP TENANT based on a session var …

   In clusters where we will promote tenant management operations, we
   would like to ensure there is one extra step needed for administrators
   to drop a tenant (and thus irremedially lose data). Given that
   `sql_safe_updates` is not set automatically when users open their
   SQL session using their own client, we need another mechanism.
   
   This change introduces the new (hidden) session var,
   `disable_drop_tenant`. When set, tenant deletion fails with the
   following error message:
   
   ```
   demo@127.0.0.1:26257/movr> drop tenant foo;
   ERROR: rejected (via sql_safe_updates or disable_drop_tenant): DROP TENANT causes irreversible data loss
   SQLSTATE: 01000
   ```
   
   (The session var `sql_safe_updates` is _also_ included as a blocker in
   the mechanism so that folk using `cockroach sql` get double
   protection).
   
   The default value of this session var is `false` in single-tenant
   clusters (set via a cluster setting `sql.drop_tenant.enabled`), for
   compatibility with CC Serverless. The default will be set to `true`
   via a config profile when suitable.
   
   Release note: None

   

   knz committed Mar 26, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 113ebcf
   • Browse repository at this point

   Copy the full SHA

   113ebcf View commit details

   Browse the repository at this point in the history