Commits on Apr 4, 2023

1. sql: adjust a couple of memory monitoring tests …

   This commit adjusts a couple of memory monitoring related tests.
   
   `TestAggregatesMonitorMemory` has been rewritten to observe the correct
   memory monitor via `crdb_internal.node_memory_monitors` virtual table.
   
   `TestEvaluatedMemoryIsChecked` is just straight up removed. Initially,
   this test was expected to verify that builtin functions like `repeat`
   perform memory accounting of the intermediate result via our memory
   accounting system. However, that changed long time ago in 2b00f15
   and now such builtins estimate their result size and return
   `errStringTooLarge` error, so the test was no longer verifying what it
   intended. This commit removes this test since we do verify the behavior
   introduced in 2b00f15 elsewhere (in the
   logic tests).
   
   Release note: None

   

   yuzefovich committed Apr 4, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 7d04684
   • Browse repository at this point

   Copy the full SHA

   7d04684 View commit details

   Browse the repository at this point in the history