release-23.1: sql: adjust a couple of memory monitoring tests #100648
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #100550.
/cc @cockroachdb/release
This commit adjusts a couple of memory monitoring related tests.
TestAggregatesMonitorMemory
has been rewritten to observe the correctmemory monitor via
crdb_internal.node_memory_monitors
virtual table.TestEvaluatedMemoryIsChecked
is just straight up removed. Initially,this test was expected to verify that builtin functions like
repeat
perform memory accounting of the intermediate result via our memory
accounting system. However, that changed long time ago in 2b00f15
and now such builtins estimate their result size and return
errStringTooLarge
error, so the test was no longer verifying what itintended. This commit removes this test since we do verify the behavior
introduced in 2b00f15 elsewhere (in the
logic tests).
Fixes: #79014.
Fixes: #100119.
Release note: None
Release justification: test-only change.