roachtest: add optional PreSetup and PostSetup hooks #101814
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
srosenberg
force-pushed
the
sr/roachtest_refactor_add_setup_phase
branch
14 times, most recently
from
f176be7
to
1847fdc
Compare
TBD: summarize Epic: none Release note: None Resolves: cockroachdb#33377
srosenberg
force-pushed
the
sr/roachtest_refactor_add_setup_phase
branch
from
1847fdc
to
fa11649
Compare
|
Note to self: this PR seems to also address: #99951 |
srosenberg
added a commit
to srosenberg/cockroach
that referenced
this pull request
Sep 12, 2023
Previously, an NPE discovered in [1] wasn't observed in any of the nightly runs, given the necessary conditions implied multiple, consecutive failures. As of recently, the NPE surfaced in nightlies. This PR fixes the NPE, and a leaked cluster allocation. The fix is intended to be temporary since a refactored test runner in [2] had already addressed it; we plan to resurrect [2] in the coming weeks. Epic: none Fixes: cockroachdb#104385 Release note: None [1] cockroachdb#104385 [2] cockroachdb#101814
craig bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
110406: roachtest: fix NPE in test_runner r=renatolabs,smg260 a=srosenberg Previously, an NPE discovered in [1] wasn't observed in any of the nightly runs, given the necessary conditions implied multiple, consecutive failures. As of recently, the NPE surfaced in nightlies. This PR fixes the NPE, and a leaked cluster allocation. The fix is intended to be temporary since a refactored test runner in [2] had already addressed it; we plan to resurrect [2] in the coming weeks. Epic: none Fixes: #104385 Release note: None [1] #104385 [2] #101814 Co-authored-by: Stan Rosenberg <stan.rosenberg@gmail.com>
blathers-crl bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
Previously, an NPE discovered in [1] wasn't observed in any of the nightly runs, given the necessary conditions implied multiple, consecutive failures. As of recently, the NPE surfaced in nightlies. This PR fixes the NPE, and a leaked cluster allocation. The fix is intended to be temporary since a refactored test runner in [2] had already addressed it; we plan to resurrect [2] in the coming weeks. Epic: none Fixes: #104385 Release note: None [1] #104385 [2] #101814
blathers-crl bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
Previously, an NPE discovered in [1] wasn't observed in any of the nightly runs, given the necessary conditions implied multiple, consecutive failures. As of recently, the NPE surfaced in nightlies. This PR fixes the NPE, and a leaked cluster allocation. The fix is intended to be temporary since a refactored test runner in [2] had already addressed it; we plan to resurrect [2] in the coming weeks. Epic: none Fixes: #104385 Release note: None [1] #104385 [2] #101814
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBD: summarize
Epic: none
Release note: None
Resolves: #33377