ugpradeccl: fix and unskip TestTenantUpgradeFailure
#101956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
The code change unskips `TestTenantUpgradeFailure` after making the following changes to fix it: 1. Bump `slinstance.DefaultTTL.Override` from 3s to 15s 2. Ensure v2 isn't higher than `TestingBinaryVersion` It also updates the registry override to let the test run all migrations. Release note: None Epic: none Closes cockroachdb#98555
healthy-pod
force-pushed
the
fix-tenant-upgrade-failure
branch
from
86eec34
to
4334dfb
Compare
|
bors r=knz |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code change unskips
TestTenantUpgradeFailureafter making the following changes to fix it:slinstance.DefaultTTL.Overridefrom 3s to 15sTestingBinaryVersionIt also updates the registry override to let the test run all migrations.
Release note: None
Epic: none
Closes #98555