colexec: remove BenchmarkLogicalProjOp as having too high variance #102513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even after making the seed constant, this benchmark has too high of a variance, so it doesn't seem that useful (actually seems to have negative value since it can show up as a huge regression on unrelated changes like this [one](https://gist.github.com/yuzefovich/0834cf0477abbd9b9ba0189970d15338) which only modified `colexechash` and `colexecjoin` packages). Epic: None Release note: None
yuzefovich
added
the
backport-23.1.x
|
This change is |
mgartner
approved these changes
May 2, 2023
There was a problem hiding this comment.
Is the high variance due to the fact that the projection is such a simple operation?
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
Yeah, that's my guess. Each operation takes on the order of a few microseconds, so it seems that it could be noticeably impacted just by code layout changes (due to unrelated changes). The absolute speed is so high that it seems to be not worth the effort to dig in further. TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even after making the seed constant, this benchmark has too high of a variance, so it doesn't seem that useful (actually seems to have negative value since it can show up as a huge regression on unrelated changes like this one which only modified
colexechashandcolexecjoinpackages).Epic: None
Release note: None