-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: add setting to control CREATE privilege on public schema #103598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafiss
requested review from
adityamaru and
michae2
and removed request for
a team
May 18, 2023 15:45
chengxiong-ruan
approved these changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Some CI failures, but looks like just need to regenerate things.
rafiss
force-pushed
the
setting-create-public-schema
branch
from
May 24, 2023 18:10
ea73f62
to
51a9861
Compare
tftr! bors r=chengxiong-ruan |
Build failed (retrying...): |
bors r- |
Canceled. |
This setting can be used to opt-in to the behavior that PostgreSQL provides, as of PG15. Release note (sql change): Added a new cluster setting named sql.auth.public_schema_create_privilege.enabled. The setting controls whether users receive `CREATE` privileges on the public schema or not. The setting applies at the time that the public schema is created, which happens whenever a database is created. The setting is true by default.
rafiss
force-pushed
the
setting-create-public-schema
branch
from
May 24, 2023 18:25
51a9861
to
cbdbf2e
Compare
bors r=chengxiong-ruan |
This PR was included in a batch that timed out, it will be automatically retried |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #70266
This setting can be used to opt-in to the behavior that PostgreSQL provides, as of PG15.
Release note (sql change): Added a new cluster setting named sql.auth.public_schema_create_privilege.enabled. The setting controls whether users receive
CREATE
privileges on the public schema or not. The setting applies at the time that the public schema is created, which happens whenever a database is created. The setting is true by default.