roachtest: get debug zip with --include-range-info #103668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed in cockroachdb#103552 that we are missing the ranges.jsons, which is sad. This flag is new as of cockroachdb#102289. Epic: none Release note: None
|
This change is |
tbg
requested review from
srosenberg and
renatolabs
and removed request for
a team
renatolabs
approved these changes
May 19, 2023
|
Hmm, mixed-version does present a challenge, good catch. I'll still merge this, as most of our testing is not on mixed-versions, and this patches up a recently introduced blind spot. TFTR! |
|
Build failed: |
|
Busted build, not this PR's fault - guessing someone bors r=renatolabs |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed in #103552 that we are
missing the ranges.jsons, which is sad.
This flag is new as of #102289.
Epic: none
Release note: None