build: upgrade go to 1.19.10 #104893
Merged
build: upgrade go to 1.19.10 #104893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rail
added
C-enhancement
|
This change is |
* [ ] Adjust the Pebble tests to run in new version. * [ ] Adjust version in Docker image ([source](./builder/Dockerfile)). * [ ] Adjust version in the TeamCity agent image ([setup script](./packer/teamcity-agent.sh)) * [ ] Rebuild and push the Docker image (following [Basic Process](#basic-process)) * [ ] Update `build/teamcity/internal/release/build-and-publish-patched-go/impl.sh` with the new version and adjust SHA256 sums as necessary. * [ ] Adjust `GO_VERSION` and `GO_FIPS_COMMIT` for the FIPS Go toolchain ([source](./teamcity/internal/release/build-and-publish-patched-go/impl-fips.sh)). * [ ] Run the `Internal / Cockroach / Build / Toolchains / Publish Patched Go for Mac` build configuration in TeamCity with your latest version of the script above. Note the job depends on another job `Build and Publish Patched Go`. That job prints out the SHA256 of all tarballs, which you will need to copy-paste into `WORKSPACE` (see below). `Publish Patched Go for Mac` is an extra step that publishes the *signed* `go` binaries for macOS. That job also prints out the SHA256 of the Mac tarballs in particular. * [ ] Adjust `--@io_bazel_rules_go//go/toolchain:sdk_version` in [.bazelrc](../.bazelrc). * [ ] Bump the version in `WORKSPACE` under `go_download_sdk`. You may need to bump [rules_go](https://github.com/bazelbuild/rules_go/releases). Also edit the filenames listed in `sdks` and update all the hashes to match what you built in the step above. * [ ] Bump the version in `WORKSPACE` under `go_download_sdk` for the FIPS version of Go (`go_sdk_fips`). * [ ] Run `./dev generate bazel` to refresh `distdir_files.bzl`, then `bazel fetch @distdir//:archives` to ensure you've updated all hashes to the correct value. * [ ] Bump the version in `builder.sh` accordingly ([source](./builder.sh#L6)). * [ ] Bump the version in `go-version-check.sh` ([source](./go-version-check.sh)), unless bumping to a new patch release. * [ ] Bump the go version in `go.mod`. * [ ] Bump the default installed version of Go in `bootstrap-debian.sh` ([source](./bootstrap/bootstrap-debian.sh)). * [ ] Replace other mentions of the older version of go (grep for `golang:<old_version>` and `go<old_version>`). * [ ] Update the `builder.dockerImage` parameter in the TeamCity [`Cockroach`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Cockroach&tab=projectParams) and [`Internal`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Internal&tab=projectParams) projects. * [ ] Ask the Developer Infrastructure team to deploy new TeamCity agent images according to [packer/README.md](./packer/README.md) Epic: none Release note: None
|
bors r=srosenberg |
|
Build failed (retrying...): |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from a6e8fbd to blathers/backport-release-23.1-104893: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
18 tasks
michae2
added a commit
to michae2/cockroach
that referenced
this pull request
Jun 15, 2023
For some reason the checksum for `go1.19.10.darwin-amd64.tar.gz` from cockroachdb#104893 didn't match for me. This one worked. I'm not sure why. Epic: None Release note: None
craig bot
pushed a commit
that referenced
this pull request
Jun 15, 2023
104936: build: fix checksum for go1.19.10.darwin-amd64.tar.gz r=rail a=michae2 For some reason the checksum for `go1.19.10.darwin-amd64.tar.gz` from #104893 didn't match for me. This one worked. I'm not sure why. Epic: None Release note: None Co-authored-by: Michael Erickson <michae2@cockroachlabs.com>
rail
pushed a commit
to rail/cockroach
that referenced
this pull request
Jun 15, 2023
For some reason the checksum for `go1.19.10.darwin-amd64.tar.gz` from cockroachdb#104893 didn't match for me. This one worked. I'm not sure why. Epic: None Release note: None
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build/teamcity/internal/release/build-and-publish-patched-go/impl.shwith the new version and adjust SHA256 sums as necessary.GO_VERSIONandGO_FIPS_COMMITfor the FIPS Go toolchain (source).Internal / Cockroach / Build / Toolchains / Publish Patched Go for Macbuild configuration in TeamCity with your latest version of the script above. Note the job depends on another jobBuild and Publish Patched Go. That job prints out the SHA256 of all tarballs, which you will need to copy-paste intoWORKSPACE(see below).Publish Patched Go for Macis an extra step that publishes the signedgobinaries for macOS. That job also prints out the SHA256 of the Mac tarballs in particular.--@io_bazel_rules_go//go/toolchain:sdk_versionin .bazelrc.WORKSPACEundergo_download_sdk. You may need to bump rules_go. Also edit the filenames listed insdksand update all the hashes to match what you built in the step above.WORKSPACEundergo_download_sdkfor the FIPS version of Go (go_sdk_fips)../dev generate bazelto refreshdistdir_files.bzl, thenbazel fetch @distdir//:archivesto ensure you've updated all hashes to the correct value.builder.shaccordingly (source).go-version-check.sh(source), unless bumping to a new patch release.go.mod.bootstrap-debian.sh(source).golang:<old_version>andgo<old_version>).builder.dockerImageparameter in the TeamCityCockroachandInternalprojects.Epic: none
Release note: None