Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: batcheval: delete flaky integration test #106670

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jul 12, 2023

Backport 1/1 commits from #106502 on behalf of @aliher1911.

/cc @cockroachdb/release


TestLeaseCommandLearnerReplica is fundamentally flaky as commit can't retry all underlying replication failures and acceptable failure causes are not exposed on the higher levels where test operates.

What test is supposed to verify that failures to propose with invalid lease are not causing pipelined writes to fail but are retried. More details described in original PR #35261 where this test is introduced.
In absence of direct controls of that, test is trying to move leases between replicas, but this action could cause different failures to happen which can't be filtered out. For example:
failed to repropose 0b9a11f4bef0e3d3 at idx 16 with new lease index: [NotLeaseHolderError] ‹reproposal failed due to closed timestamp›
and
stale proposal: command was proposed under lease #2 but is being applied under lease: ...
While closed timestamp could be mitigated by changing settings, second one is opaque to the caller and hard to filter out.

Release note: None
Fixes #104716


Release justification:

TestLeaseCommandLearnerReplica is fundamentally flaky as commit can't
retry all underlying replication failures and acceptable failure causes
are not exposed on the higher levels where test operates.

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner July 12, 2023 08:44
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-106502 branch from 7496dba to 9e83589 Compare July 12, 2023 08:44
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jul 12, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-106502 branch from 51c9b3b to a298b71 Compare July 12, 2023 08:44
@blathers-crl
Copy link
Author

blathers-crl bot commented Jul 12, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested a review from tbg July 12, 2023 08:44
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@aliher1911 aliher1911 merged commit f68123e into release-23.1 Jul 20, 2023
@aliher1911 aliher1911 deleted the blathers/backport-release-23.1-106502 branch July 20, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants