democluster: fix a flake in TestTransientClusterMultitenant #106679
Conversation
Prior to this patch, the test was passing a cancel-on-quiesce context to the `Start` call. This was invalid, because this context is then passed recursively to server tasks that need to continue to run during graceful shutdown. This patch ensures that the Start call uses a regular context instead. The patch also makes a few other improvements to the test. Release note: None
|
This change is |
knz
added
A-multitenancy
| require.NoError(t, conn.Exec(ctx, "CREATE TABLE a (a int PRIMARY KEY)")) | ||
|
|
||
| log.Infof(ctx, "test succeeded") | ||
| t.Log("test succeeded") |
There was a problem hiding this comment.
In case it shows up during review: this logging helps troubleshoot when looking at the log output.
|
TFYR! bors r=herkolategan |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from fea98e4 to blathers/backport-release-22.2-106679: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. error setting reviewers, but backport branch blathers/backport-release-23.1-106679 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/106690/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. [] Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Fixes #96162.
Epic: CRDB-18499
Prior to this patch, the test was passing a cancel-on-quiesce context to the
Startcall. This was invalid, because this context is then passed recursively to server tasks that need to continue to run during graceful shutdown.This patch ensures that the Start call uses a regular context instead.
The patch also makes a few other improvements to the test.
(I could readily repro the flake under stress within 100-200 iterations before this patch. After this patch, it doesn't repro after 500 iterations.)