server: minor improvement around TestTenantInterface #107086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mostly adds `serverutils.` prefix to the interface names which allows for easier navigation (at least in the GoLand). Release note: None
Tracer method is already in TestTenantInterface. Release note: None
Previously, if `TestServer.Start` returned an error while the default test tenant wasn't disabled, we'd incorrectly consider that we had started the default test tenant. This, then, could lead to some problems (e.g. trying to access non-existing tenant which could lead to a crash). This is fixed by checking whether we have test tenants. Release note: None
We simply needed to use the ExecutorConfig of the test tenant if it was started. Release note: None
yuzefovich
requested review from
smg260 and
renatolabs
and removed request for
a team
|
This change is |
knz
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 3 of 3 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @renatolabs, @smg260, and @stevendanna)
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #76378.
Fixes: #106903.