opt: fix memo cycle test in dbg builds
#107202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
In cockroachdb#106944 the `dbg` compilation mode became the default for all non-release builds. This caused stack overflows in the memo cycle detection tests, which excessive invoke recursive functions, likely because stack frames are larger in `dbg` mode than in `opt` mode or because certain optimizations aren't performed in `dbg` mode that reduce stack depth due to recursion, like inlining. This commit fixes the test by lowering the cycle detection limit, making it so that a cycle is detected before a stack overflow occurs. Epic: None Release note: None
rharding6373
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @michae2 and @rickystewart)
rickystewart
approved these changes
Jul 19, 2023
|
This may not be necessary once #107207 is merged. |
|
#107207 fixed the test failure, so I'll close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #106944 the
dbgcompilation mode became the default for allnon-release builds. This caused stack overflows in the memo cycle
detection tests, which excessive invoke recursive functions, likely
because stack frames are larger in
dbgmode than inoptmode orbecause certain optimizations aren't performed in
dbgmode that reducestack depth due to recursion, like inlining.
This commit fixes the test by lowering the cycle detection limit, making
it so that a cycle is detected before a stack overflow occurs.
Epic: None
Release note: None