Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: deflake TestServerShutdownReleasesSession #107727

Merged
merged 1 commit into from
Jul 28, 2023
Merged

server: deflake TestServerShutdownReleasesSession #107727

merged 1 commit into from
Jul 28, 2023

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Jul 27, 2023

The tenant was not being fully stopped, so the test could encounter flakes.

fixes #107592
Release note: None

@rafiss
server: deflake TestServerShutdownReleasesSession
9cde0a6 
The tenant was not being fully stopped, so the test could encounter
flakes.

Release note: None
@rafiss rafiss requested a review from jeffswenson July 27, 2023 16:52
@rafiss rafiss requested review from a team as code owners July 27, 2023 16:52
@rafiss rafiss requested a review from knz July 27, 2023 16:52
@rafiss rafiss mentioned this pull request Jul 27, 2023
Closed
@cockroach-teamcity
Copy link
Member

This change is Reviewable

chengxiong-ruan
chengxiong-ruan approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@chengxiong-ruan chengxiong-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

@rafiss
Copy link
Collaborator Author

rafiss commented Jul 27, 2023

flake was in a different test (TestTxnObeysTableModificationTime tracked in #107159)

bors r+

@craig
Copy link
Contributor

craig bot commented Jul 27, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jul 27, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jul 28, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jul 28, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jul 28, 2023

This PR was included in a batch that was canceled, it will be automatically retried

@craig craig bot merged commit 04c91a5 into cockroachdb:master Jul 28, 2023
@craig
Copy link
Contributor

craig bot commented Jul 28, 2023

Build succeeded:

@jeffswenson
Copy link
Collaborator

Good catch. Thanks!

@rafiss rafiss deleted the deflake-TestServerShutdownReleasesSession branch August 1, 2023 03:56
@rafiss rafiss mentioned this pull request Aug 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengxiong-ruan chengxiong-ruan chengxiong-ruan approved these changes

@knz knz knz approved these changes

@jeffswenson jeffswenson Awaiting requested review from jeffswenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

server: TestServerShutdownReleasesSession failed
5 participants
@rafiss @cockroach-teamcity @jeffswenson @knz @chengxiong-ruan