Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: sql: Delete invalid TestDropColumnAfterMutations test #107763

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jul 27, 2023

Backport 1/1 commits from #107489 on behalf of @rimadeodhar.

/cc @cockroachdb/release


This test checks the functionality for the following sequence of events:

  1. A txn adds a constraint to a column on a table.
  2. A separate txn drops the column.

However, this interaction between the two txns has been made explicit by the PR #92289. Since this PR, step (2) will fail if the constraint in step (1) is in the process of being added. As a result, the elaborate set up and sequence of events being tested in TestDropColumnAfterMutations is no longer necessary.

Release note: none
Epic: none
Fixes: #76843


Release justification: test only change

This test checks the functionality for the following sequence
of events:
1. A txn adds a constraint to a column on a table.
2. A separate txn drops the column.

However, this interaction between the two txns has been
made explicit by the PR #92289.
Since this PR, step (2) will fail if the constraint in step (1)
is in the process of being added. As a result, the elaborate
set up and sequence of events being tested in TestDropColumnAfterMutations
is no longer necessary.

Release note: none
Epic: none
Fixes: #76843
@blathers-crl blathers-crl bot requested a review from a team as a code owner July 27, 2023 22:51
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-107489 branch from 2b689f8 to 58a4792 Compare July 27, 2023 22:51
@blathers-crl
Copy link
Author

blathers-crl bot commented Jul 27, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jul 27, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-107489 branch from 47c5e19 to 121fe02 Compare July 27, 2023 22:51
@blathers-crl blathers-crl bot requested a review from postamar July 27, 2023 22:51
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss merged commit f698eca into release-23.1 Jul 28, 2023
@rafiss rafiss deleted the blathers/backport-release-23.1-107489 branch July 28, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants