-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server, all: rename some cluster settings #109415
Conversation
I think we should name it Also, out of curiosity, why Another naming scheme to consider is: |
RFAL
Done.
As per the guidelines: |
7caa112
to
08d84d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tyvm!
The following settings have been renamed, to emphasize how the initial drain wait is a *mandatory waits*, whereas the others are simply *timeouts*. Release note (cli change): The following cluster settings have been renamed; the previous names remain available for backward-compatibility. | Previous name | New Name | |---------------------------------------|----------------------------------------------------| | `server.shutdown.drain_wait` | `server.shutdown.initial_wait` | | `server.shutdown.lease_transfer_wait` | `server.shutdown.lease_transfer_iteration.timeout` | | `server.shutdown.query_wait` | `server.shutdown.queries.timeout` | | `server.shutdown.connection_wait` | `server.shutdown.transactions.timeout` | | `server.shutdown.jobs_wait` | `server.shutdown.jobs.timeout` |
TFYR! bors r=rafiss |
Build succeeded: |
Fixes #75520.
Epic: CRDB-28893
The following settings have been renamed, to emphasize how the initial drain wait is a mandatory wait, whereas the others are simply timeouts.
Release note (cli change): The following cluster settings have been renamed; the previous names remain available for
backward-compatibility.
server.shutdown.drain_wait
server.shutdown.initial_wait
server.shutdown.lease_transfer_wait
server.shutdown.lease_transfer_iteration.timeout
server.shutdown.query_wait
server.shutdown.queries.timeout
server.shutdown.connection_wait
server.shutdown.transactions.timeout
server.shutdown.jobs_wait
server.shutdown.jobs.timeout