Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/server: add an extra server startup guardrail #110377

Merged
merged 1 commit into from
Sep 28, 2023
Merged

pkg/server: add an extra server startup guardrail #110377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pkg/server/server_sql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1650,6 +1650,16 @@ func (s *SQLServer) preStart(
"use a tenant binary whose version is at least %v", tenantActiveVersion.Version)
}

// Prevent the server from starting if its minimum supported binary version is too high
// for the tenant cluster version.
if tenantActiveVersion.Version.Less(s.execCfg.Settings.Version.BinaryMinSupportedVersion()) {
return errors.WithHintf(errors.Newf("preventing SQL server from starting because its executable "+
"version is too new to run the current active logical version of the virtual cluster"),
"finalize the virtual cluster version to at least %v or downgrade the"+
"executable version to at most %v", s.execCfg.Settings.Version.BinaryMinSupportedVersion(), tenantActiveVersion.Version,
)
}

// Delete all orphaned table leases created by a prior instance of this
// node. This also uses SQL.
s.leaseMgr.DeleteOrphanedLeases(ctx, orphanedLeasesTimeThresholdNanos)
Expand Down