sql: fix gist decoding in foreign DB #110966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
When a gist is exported and decoded in a foreign DB it should still decode w/o panic. If a table scan result columns are fed into a group by column the group by column code expects the result columns to be in tact and panics. Fix this by making fake "unknown" result columns so we can print the plan. Making this change led to an unintended change in gists_tpce, this is because the catalog was shared between the test files and I added a table. Fix this for the future by creating a new catalog for each file. But with this change the table ids encoded in the gists_tpce got smaller. Epic: None Fixes: cockroachdb#110964 Release note (bug fix): Fixed panic when decoding gist in DB without the table referred to by the gist.
cucaroach
requested review from
michae2 and
a team
and removed request for
a team
michae2
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @cucaroach)
|
bors r+ |
|
bors timed out, courtesy merge bors r+ |
|
This PR was included in a batch that timed out, it will be automatically retried |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a gist is exported and decoded in a foreign DB it should still
decode w/o panic. If a table scan result columns are fed into a
group by column the group by column code expects the result columns to
be in tact and panics. Fix this by making fake "unknown" result columns
so we can print the plan.
Making this change led to an unintended change in gists_tpce, this is
because the catalog was shared between the test files and I added a
table. Fix this for the future by creating a new catalog for each file.
But with this change the table ids encoded in the gists_tpce got
smaller.
Epic: None
Fixes: #110964
Release note (bug fix): Fixed panic when decoding gist in DB without the
table referred to by the gist.