Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: sql/tests: avoid contention in RSG test #111152

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 22, 2023

Backport 1/1 commits from #111108 on behalf of @rafiss.

/cc @cockroachdb/release


TestRandomSyntaxSchemaChangeColumn would always operate on the same table, which would cause many schema changes to get queued up, since everything happens concurrently. This isn't even that realistic, so now it does the schema change on one of 50 tables randomly.

fixes #111096
Release note: None


Release justification: test only change

TestRandomSyntaxSchemaChangeColumn would always operate on the same
table, which would cause many schema changes to get queued up, since
everything happens concurrently. This isn't even that realistic, so now
it does the schema change on one of 50 tables randomly.

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner September 22, 2023 22:44
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-111108 branch from 65df41b to dfcef7f Compare September 22, 2023 22:44
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Sep 22, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-111108 branch from 876755d to a3a9e15 Compare September 22, 2023 22:44
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 22, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested a review from fqazi September 22, 2023 22:44
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Sep 22, 2023
@blathers-crl blathers-crl bot requested a review from rafiss September 22, 2023 22:44
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss merged commit b08ec85 into release-23.1 Sep 24, 2023
2 checks passed
@rafiss rafiss deleted the blathers/backport-release-23.1-111108 branch September 24, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants