-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloud/azure: Fix azure schemes #111217
cloud/azure: Fix azure schemes #111217
Conversation
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
The change LGTM but I think we should add a few tests so that if this breaks in the future we have something that fails? |
674613c
to
07fc55d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up, as discussed offline it'd be useful to either add a few lines to the integration tests or just smoke test e2e since CDC also registers azure
schemes but with their own custom validator.
07fc55d
to
68244cb
Compare
Done, how's this look? |
68244cb
to
1db0ec4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
1db0ec4
to
d5b19db
Compare
Part of: https://cockroachlabs.atlassian.net/browse/CRDB-31120 Release note (bug fix): Fixes azure schemes in storage, kms and external conns.
d5b19db
to
5cd4c7b
Compare
bors r+ |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 5cd4c7b to blathers/backport-release-22.2-111217: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
@benbardin apologies I should've pointed this out earlier. @mdlinville indicated that it would help to flesh out the release note so that the appropriate changes can be made in the docs across releases. |
111286: release-22.2: cloud/azure: Fix azure schemes r=benbardin a=benbardin Backport 1/1 commits from #111217. /cc `@cockroachdb/release` --- Part of: https://cockroachlabs.atlassian.net/browse/CRDB-31120 Release note (bug fix): Fixes azure schemes in storage and external conns. Release justification: bugfix Co-authored-by: Ben Bardin <bardin@cockroachlabs.com>
We synced offline and came up with a good release note. :) |
Yes, thanks Matt! I also added appropriate variants of the notes to the backported versions. |
Part of: https://cockroachlabs.atlassian.net/browse/CRDB-31120
Release note (bug fix): Fixes azure schemes in storage, kms and external conns.