roachprod: fix createTenantCertBundle script #111521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herkolategan
requested review from
srosenberg and
smg260
and removed request for
a team
|
This change is |
The `createTenantCertBundle` function has a script in it that has erroneous "+" characters which results in an error when trying to start a secure cluster. This change removes those characters. Epic: None Release Note: None
herkolategan
force-pushed
the
hbl/mt-fix-cert-cmd
branch
from
460a1fa to
6c6c34e
Compare
andy-kimball
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @smg260 and @srosenberg)
|
TFTR! |
craig bot
pushed a commit
that referenced
this pull request
Sep 29, 2023
111441: goschedstats: reduce underloadedRunnablePerProcThreshold r=aadityasondhi a=sumeerbhola By reducing this threshold, we more often sample the stats at 1ms intervals, which is desirable for admission control slot adjustment. Fixes #111125 Epic: none Release note: None 111521: roachprod: fix createTenantCertBundle script r=andy-kimball a=herkolategan The `createTenantCertBundle` function has a script in it that has erroneous "+" characters which results in an error when trying to start a secure cluster. This change removes those characters. Epic: None Release Note: None Co-authored-by: sumeerbhola <sumeer@cockroachlabs.com> Co-authored-by: Herko Lategan <herko@cockroachlabs.com>
|
Build succeeded: |
|
blathers backport 23.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
createTenantCertBundlefunction has a script in it that has erroneous "+" characters which results in an error when trying to start a secure cluster. This change removes those characters.Epic: None
Release Note: None