Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: sql: cache role existence checks to fix perf regression #112110

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Oct 10, 2023

Backport 1/1 commits from #111934 on behalf of @rafiss.

/cc @cockroachdb/release


In 12ec26f, we started to check for the existence of a role whenever a privilege for the public role was checked. This can hapen multiple times during some pg_catalog queries, so it introduced a performance regression.

Now, the role existence is cached so we avoid the penalty. The existence of a role is cached for the duration of the entire transaction, and also gets inherited by any internal executor used to implement a command run by the user's transaction.

No release note since this is new in 23.2.

informs #20718
fixes #112102
Release note: None


Release justification: fix a performance regression

In 12ec26f, we started to check for the
existence of a role whenever a privilege for the public role was
checked. This can hapen multiple times during some pg_catalog queries,
so it introduced a performance regression.

Now, the role existence is cached so we avoid the penalty. The existence
of a role is cached for the duration of the entire transaction, and also
gets inherited by any internal executor used to implement a command run
by the user's transaction.

No release note since this is new in 23.2.

Release note: None
@blathers-crl blathers-crl bot requested review from a team as code owners October 10, 2023 17:38
@blathers-crl blathers-crl bot requested review from michae2 and removed request for a team October 10, 2023 17:38
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 10, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-111934 branch from 081df13 to af2fa1a Compare October 10, 2023 17:38
@blathers-crl
Copy link
Author

blathers-crl bot commented Oct 10, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested a review from DrewKimball October 10, 2023 17:38
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Oct 10, 2023
@blathers-crl blathers-crl bot requested review from ecwall and rafiss October 10, 2023 17:38
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss merged commit bcbe369 into release-23.2 Oct 10, 2023
@rafiss rafiss deleted the blathers/backport-release-23.2-111934 branch October 10, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants