Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: increase write load acct test allowance by 1 #114270

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

kvoli
Copy link
Collaborator

@kvoli kvoli commented Nov 10, 2023

TestWriteLoadStatsAccounting asserts that the replica load tracker matches the sent write counts. Flakes can occur due to retries, interleaving requests, etc. Bump the error allowance from 4 to 5.

Resolves: #114239
Release note: None

@kvoli kvoli self-assigned this Nov 10, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

`TestWriteLoadStatsAccounting` asserts that the replica load tracker
matches the sent write counts. Flakes can occur due to retries,
interleaving requests, etc. Bump the error allowance from 4 to
5.

Resolves: cockroachdb#114239
Release note: None
@kvoli kvoli force-pushed the 231110-deflake-write-metric-acct branch from 457b967 to cfaf277 Compare November 13, 2023 14:23
@kvoli kvoli marked this pull request as ready for review November 16, 2023 22:12
@kvoli kvoli requested a review from a team as a code owner November 16, 2023 22:12
Copy link
Collaborator

@andrewbaptist andrewbaptist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@kvoli
Copy link
Collaborator Author

kvoli commented Dec 20, 2023

TYFTR

bors r=andrewbaptist

@craig
Copy link
Contributor

craig bot commented Dec 20, 2023

Build succeeded:

@craig craig bot merged commit d8fefa0 into cockroachdb:master Dec 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kv/kvserver: TestWriteLoadStatsAccounting failed
3 participants