Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #11759

Merged
merged 1 commit into from
Dec 1, 2016
Merged

Update dependencies #11759

merged 1 commit into from
Dec 1, 2016

Conversation

tamird
Copy link
Contributor

@tamird tamird commented Dec 1, 2016

Temporarily use https://github.com/tamird/go-deadlock to pick up
sasha-s/go-deadlock#2.

Tons of changes to staticcheck, but nothing new was flagged. See
dominikh/go-staticcheck@1808e1b...66144fd


This change is Reviewable

Temporarily use https://github.com/tamird/go-deadlock to pick up
sasha-s/go-deadlock#2.

Tons of changes to staticcheck, but nothing new was flagged. See
dominikh/go-staticcheck@1808e1b...66144fd
Copy link
Member

@jordanlewis jordanlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM without having actually checked all the dependency updates

checker.WholeProgram = true
funcs := map[string]lint.Func{
"U1000": unused.NewLintRunner(checker),
type metaChecker struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are all these changes? Care to explain in the commit message?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tamird tamird merged commit d4b90e2 into cockroachdb:master Dec 1, 2016
@tamird tamird deleted the faster-deadlock branch December 1, 2016 21:41
@dt dt mentioned this pull request Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants