release-23.2: sql: deflake TestTrackOnlyUserOpenTransactionsAndActiveStatements #120566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #120505 on behalf of @rafiss.
/cc @cockroachdb/release
This changes the test to block in AfterExecute rather than OnTxnFinish, which should make the active statements assertion less flaky.
It also fixes a testing bug where the SELECT FOR UPDATE was not in a txn.
fixes #120042
fixes #120235
fixes #119829
Release note: None
Release justification: test only change