storage: bump Pebble, check external ingestions in test mode #122323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * [`6a4bcf5f`](cockroachdb/pebble@6a4bcf5f) db: check for empty external ingestions * [`1eab9d61`](cockroachdb/pebble@1eab9d61) db: simplify levelIter skipEmptyFileForward * [`e7662630`](cockroachdb/pebble@e7662630) db: refactor Reader.Get * [`cf40ae78`](cockroachdb/pebble@cf40ae78) metamorphic: don't set synthetic suffix if there are duplicate prefixes Release note: none. Epic: none.
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
jbowens
approved these changes
Apr 13, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @msbutler)
|
TFTR! bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go.mod: bump Pebble to 6a4bcf5f1aec
Changes:
6a4bcf5fdb: check for empty external ingestions1eab9d61db: simplify levelIter skipEmptyFileForwarde7662630db: refactor Reader.Getcf40ae78metamorphic: don't set synthetic suffix if there are duplicate prefixesRelease note: none.
Epic: none.
storage: check external ingestions in test mode
Informs #122176