dev: fix staging behavior from non-default configurations #123241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
rickystewart
added
the
backport-24.1.x
We added support for building in non-default configurations/compilation modes in a previous PR, but this was buggy and we were never actually using the configuration arguments in `bazel info`, so staging was always happening from the `fastbuild` location. This PR fixes that buggy behavior, so staging will happen from the appropriate source location. Epic: CRDB-17171 Release note: None
rickystewart
force-pushed
the
fix-dev-staging-behavior
branch
from
9b06e80
to
678be4e
Compare
rail
approved these changes
Apr 29, 2024
|
bors r=rail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added support for building in non-default configurations/compilation modes in a previous PR, but this was buggy and we were never actually using the configuration arguments in
bazel info, so staging was always happening from thefastbuildlocation. This PR fixes that buggy behavior, so staging will happen from the appropriate source location.Epic: CRDB-17171
Release note: None