streamingccl/logical: remove extra/disused metrics, cleanup var names #125901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
stevendanna
approved these changes
Jun 19, 2024
Release note: none. Epic: none.
Release note: none. Epic: none.
dt
requested review from
nameisbhaskar and
vidit-bhat
and removed request for
a team
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Release note: none. Epic: none.
Release note: none. Epic: none.
Release note: none. Epic: none.
We have this in the histogram counts. Release note: none. Epic: none.
the number of rows in an apply batch is useful, but at this level the byte count is not. Release note: none. Epic: none.
This cleans up the in-code names of the metrics in the logical package, to use StreamBatch or ApplyBatch and standardize on Hist suffix appearing last, and to have the meta names match the field names. A follow-up change may update the persisted names and the dashboard accordingly; this change is only changing the in-code variable names. Release note: none. Epic: none.
|
TFTR! bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits.