roachtest: improve logging in gossip/chaos/nodes=9 further #126087
Conversation
Informs cockroachdb#124828. Informs cockroachdb#126077. Release note: None
nvanbenschoten
requested review from
nameisbhaskar and
vidit-bhat
and removed request for
a team
|
This change is |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @nameisbhaskar, @nvanbenschoten, and @vidit-bhat)
pkg/cmd/roachtest/tests/gossip.go line 126 at r1 (raw file):
start := timeutil.Now() for { t.L().Printf("checking if gossip excludes dead node %d (%.0fs)\n",
nit: dead node %d; have been checking since?
There was a problem hiding this comment.
TFTR!
bors r+
Reviewable status:
pkg/cmd/roachtest/tests/gossip.go line 126 at r1 (raw file):
Previously, arulajmani (Arul Ajmani) wrote…
nit: dead node %d; have been checking since?
We should keep this consistent with all of the logging in gossipOK, so I'll keep this as is for now.
There was a problem hiding this comment.
Reviewable status:
pkg/cmd/roachtest/tests/gossip.go line 126 at r1 (raw file):
Previously, nvanbenschoten (Nathan VanBenschoten) wrote…
We should keep this consistent with all of the logging in
gossipOK, so I'll keep this as is for now.
Ack
Informs #124828.
Informs #126077.
Release note: None