Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: change 'Physcial Replication Producer' category to 'Replication Producer' #127374

Merged
merged 3 commits into from
Jul 18, 2024
Merged

ui: change 'Physcial Replication Producer' category to 'Replication Producer' #127374

merged 3 commits into from
Jul 18, 2024

Conversation

msbutler
Copy link
Collaborator

@msbutler msbutler commented Jul 17, 2024 •
edited
Loading

Epic: none

Release note: none

@msbutler msbutler added T-disaster-recovery backport-24.2.x Flags PRs that need to be backported to 24.2 labels Jul 17, 2024
@msbutler msbutler requested a review from ajstorm July 17, 2024 18:06
@msbutler msbutler self-assigned this Jul 17, 2024
@msbutler msbutler requested review from a team as code owners July 17, 2024 18:06
@msbutler msbutler requested review from xinhaoz and removed request for a team July 17, 2024 18:06
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@msbutler msbutler force-pushed the butler-remove-physical-label branch from 7b8691d to 266c014 Compare July 17, 2024 18:06
@msbutler msbutler changed the title Butler remove physical label ui: change 'Physcial Replication Producer' category to 'Replication Producer' Jul 17, 2024
@msbutler
ui: add Logical Replication Ingestion Category
1efa26e 
Epic: none

Release note: none
@msbutler msbutler force-pushed the butler-remove-physical-label branch from 11d1202 to 520dad7 Compare July 18, 2024 01:07
stevendanna
stevendanna approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@stevendanna stevendanna left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@msbutler
Copy link
Collaborator Author

TFTR!

bors r=stevendanna

craig bot pushed a commit that referenced this pull request Jul 18, 2024
@msbutler
Merge #127374
ea57217 
127374: ui: change 'Physcial Replication Producer' category to 'Replication Producer' r=stevendanna a=msbutler

Epic: none

Release note: none

Co-authored-by: Michael Butler <butler@cockroachlabs.com>
@craig
Copy link
Contributor

craig bot commented Jul 18, 2024

Build failed:

@msbutler
Copy link
Collaborator Author

bors r-

@msbutler msbutler force-pushed the butler-remove-physical-label branch 2 times, most recently from dd9d1cc to b6204b6 Compare July 18, 2024 15:45
@msbutler
ui: only show LDR badge on jobs page
8e7952d 
The patch avoids showing the fraction completed on the jobs page for LDR
because it doesn't mean anything.

Epic: none

Release note: none
@msbutler msbutler force-pushed the butler-remove-physical-label branch from b6204b6 to 8e7952d Compare July 18, 2024 16:11
@msbutler
Copy link
Collaborator Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jul 18, 2024

Build succeeded:

@craig craig bot merged commit 6154ebf into cockroachdb:master Jul 18, 2024
22 checks passed
@blathers-crl blathers-crl bot mentioned this pull request Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevendanna stevendanna stevendanna approved these changes

@ajstorm ajstorm Awaiting requested review from ajstorm

@xinhaoz xinhaoz Awaiting requested review from xinhaoz xinhaoz is a code owner automatically assigned from cockroachdb/obs-prs

Assignees

@msbutler msbutler

Labels
backport-24.2.x Flags PRs that need to be backported to 24.2 T-disaster-recovery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msbutler @cockroach-teamcity @stevendanna