roachtest: rename DSC job compat test for 24.3; avoid pooling #127404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafiss
requested review from
nameisbhaskar and
vidit-bhat
and removed request for
a team
|
This change is |
annrpom
approved these changes
Jul 17, 2024
pkg/cmd/roachtest/tests/mixed_version_job_compatibility_in_declarative_schema_changer.go
Show resolved
Hide resolved
ignore this (edit: spoke offline about this) |
This makes sure that session variables have their intended effect. Release note: None
Release note: None
|
Only the first commit here should backported in order to fix #124791 bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
127210: pkg/cli: add --locality-file to server start commands r=JeffSwenson a=jaylim-crl Previously, we can only specify locality configurations via the --locality flag. This commit introduces a new --locality-file flag to all server start commands (i.e. start, start-single-node, and mt start-sql), and would allow us to specify locality configurations via a file. Note that for the specified file, all leading and trailing whitespaces will be trimmed before processing. This addresses a situation in CockroachDB Cloud where we are unable to access the locality of the SQL servers during process startup, and we need to populate this after. CockroachDB Cloud runs SQL pods for Serverless via the `mt start-sql` subcommand, alongside with the `--tenant-id-file` flag. When such a flag is specified, we will defer the loading of the locality file until the tenant ID has been read. This would allow us to populate the locality file during runtime (i.e. after the cockroach process has fully started). Epic: none Release note (cli change): A new `--locality-file` flag has been added to all server start commands. With this flag, locality configurations can be specified via a file, and this has the same effect as providing the file's contents directly via the `--locality` flag. 127404: roachtest: add 24.2 DDLs to DSC job compat test; avoid pooling r=rafiss a=rafiss See individual commits. fixes #124442 fixes #124791 Release note: None Co-authored-by: Jay <jay@cockroachlabs.com> Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
rafiss
changed the title
|
bors retry |
This was referenced Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
fixes #124442
fixes #124791
Release note: None