backupccl: update restore job description #127970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
msbutler
approved these changes
Jul 31, 2024
pkg/ccl/backupccl/backup_test.go
Outdated
| @@ -1239,12 +1217,12 @@ func TestBackupRestoreSystemJobs(t *testing.T) { | |||
| sqlDB.Exec(t, `RESTORE TABLE bank FROM LATEST IN $1 WITH OPTIONS (into_db='restoredb')`, collectionDir) | |||
|
|
|||
| //TODO(kev-cao): fix the restore description when restoring from a backup tree | |||
Previously, restore job description follows the old syntax
`RESTORE ... FROM`, this PR updates the job description
such that it reflects the new syntax:
`RESTORE FROM {backup} IN {collectionURI}`.
Epic: none
Fixes: cockroachdb#127728
Release note (bug fix): Updated restore job description from
`RESTORE ... FROM` to `RESTORE FROM {backup} IN {collectionURI}`
to reflect the new restore syntax.
azhu-crl
force-pushed
the
update-restore-description
branch
from
85d4cd2
to
7f7a528
Compare
|
TFTR! bors r=msbutler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, restore job description follows the old syntax
RESTORE ... FROM, this PR updates the job description such that it reflects the new syntax:RESTORE FROM {backup} IN {collectionURI}.Epic: none
Fixes: #127728
Release note (bug fix): Updated restore job description from
RESTORE ... FROMtoRESTORE FROM {backup} IN {collectionURI}to reflect the new restore syntax.