roachprod: azure destroy cluster returns error if no resource group was found #128969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarrylWong
requested review from
srosenberg and
renatolabs
and removed request for
a team
|
This change is |
srosenberg
reviewed
Aug 14, 2024
pkg/roachprod/vm/azure/azure.go
Outdated
| @@ -495,6 +495,10 @@ func (p *Provider) DeleteCluster(l *logger.Logger, name string) error { | |||
| } | |||
| } | |||
|
|
|||
| if len(futures) == 0 { | |||
| return errors.Newf("DeleteCluster: Found no azure resource groups with tag cluster: %s", name) | |||
There was a problem hiding this comment.
How will this error show up in the slack channel? E.g., will it be lots of flashing red signs, so we won't miss it? :)
There was a problem hiding this comment.
Maybe we can add a **** MANUAL INTERVENTION REQUIRED **** banner here so it's harder to miss. My understanding is that this error would be printed every hour, so there's a good chance we would notice soon.
DarrylWong
force-pushed
the
azure-destroy-cluster
branch
from
b369dc5
to
7ce7cde
Compare
renatolabs
approved these changes
Aug 14, 2024
srosenberg
approved these changes
Aug 14, 2024
|
TFTRs! bors r=renatolabs, srosenberg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: none
Release note: none
Epic: none