-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kv,sql,storage: avoid various allocs #137569
Open
tbg
wants to merge
12
commits into
cockroachdb:master
Choose a base branch
from
tbg:vevent
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+96
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was around 0.5% of allocs in oltp_write_only. The account is always populated on the "real hot path" reads, but there are also the similarly hot but not "as real" reads for the abort span, loading the GC hint, and so on. These are not using the kvserver-level bound account and so benefit from this pooling.
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Only alloc when tracing.
we were unconditionally heap allocationg `ba.ShallowCopy`, for 0.6% of allocs on oltp_write_only.
I actually don't understand why this allocated. Escape analysis said: > func literal escapes to heap: flow: {heap} = > &{storage for func literal}: from func literal (spill) at <the defer> This remained true even after simplifying the code (so that `iter, err` were local to the block) but keeping the `defer`. This was 0.41% on oltp_write_only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
abandon
closure in hot path