kvserver: alias range_id in flow control integration tests #138085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were duplicated around many tests in `flow_control_integration_test.go`. De-duplicate. Part of: cockroachdb#137727 Release note: None
The SQL query strings which are reused across several `TestFlowControl.*` tests were inconsistently formatted. Format them consistently, although not following any style guide. Part of: cockroachdb#137727 Release note: None
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
Previously, the `range_id` of scratch ranges used in various `TestFlowControl.*` tests would be printed into the testdata file. This made it tedious to introduce new system tables, which in turn may create new ranges and necessitate regenerating the `test_flow_control_integration` testdata files to pick up the higher default scratch range id. Alias the range id to letters in `a,b,...,z` so that regardless of the underlying scratch range id changing, the aliased scratch range id remains unchanged. For example: An old example: ```sql SELECT range_id, count(*) AS streams FROM crdb_internal.kv_flow_control_handles GROUP BY (range_id) ORDER BY streams DESC; range_id | stream_count -----------+--------------- 75 | 3 76 | 3 ``` Now looks like: ```sql SELECT chr(96 + dense_rank() OVER (ORDER BY range_id)) as range_id, count(*) AS streams FROM crdb_internal.kv_flow_control_handles GROUP BY range_id ORDER BY range_id; range_id | stream_count -----------+--------------- a | 3 b | 3 ``` Resolves: cockroachdb#137727 Release note: None
kvoli
force-pushed
the
241230.rac-stop-printing-range-id
branch
from
5e14604 to
6975c56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier commits are mechanical, reformatting and deduplicating SQL queries
used by the flow control integration tests.
Previously, the
range_idof scratch ranges used in variousTestFlowControl.*tests would be printed into the testdata file. Thismade it tedious to introduce new system tables, which in turn may create
new ranges and necessitate regenerating the
test_flow_control_integrationtestdata files to pick up the higherdefault scratch range id.
Alias the range id to letters in
a,b,...,zso that regardless of theunderlying scratch range id changing, the aliased scratch range id
remains unchanged. For example:
An old example:
Now looks like:
Resolves: #137727
Release note: None