Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccl/multiregionccl: deflake TestRegionLivenessProberForLeases #138088

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

annrpom
Copy link
Contributor

@annrpom annrpom commented Dec 30, 2024

In our TestingRequestFilter, we should ensure that the length of our delete request key is at least the same length as the prefix key; otherwise, we risk indexing out of bounds during our prefix key check.

Epic: none
Fixes: #138058

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@annrpom annrpom marked this pull request as ready for review January 8, 2025 20:33
@annrpom annrpom requested a review from a team as a code owner January 8, 2025 20:33
Copy link
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @annrpom)

In our `TestingRequestFilter`, we should ensure that the length
of our delete request key is at least the same length as the prefix
key; otherwise, we risk indexing out of bounds during our prefix
key check.

Epic: none
Fixes: cockroachdb#138058

Release note: None
@annrpom annrpom force-pushed the protect-bounds-prefix branch from 15742d3 to 391fc1c Compare January 8, 2025 20:35
@annrpom
Copy link
Contributor Author

annrpom commented Jan 8, 2025

rebased; TFTR! ('-')7

@rafiss rafiss added backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1. backport-24.2.x Flags PRs that need to be backported to 24.2 backport-24.3.x Flags PRs that need to be backported to 24.3 labels Jan 8, 2025
@annrpom
Copy link
Contributor Author

annrpom commented Jan 8, 2025

bors r+

@craig craig bot merged commit 164ce7c into cockroachdb:master Jan 8, 2025
22 checks passed
Copy link

blathers-crl bot commented Jan 8, 2025

Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches.


Issue #138058: branch-release-23.2, branch-release-24.1, branch-release-24.2, branch-release-24.3.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Copy link

blathers-crl bot commented Jan 8, 2025

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 391fc1c to blathers/backport-release-23.2-138088: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1. backport-24.2.x Flags PRs that need to be backported to 24.2 backport-24.3.x Flags PRs that need to be backported to 24.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ccl/multiregionccl: TestRegionLivenessProberForLeases failed [slice bounds out of range]
4 participants