Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rttanalysis: avoid tracing during non-validation benchmark #138090

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Dec 30, 2024

The benchmarks in this package were all capturing statement traces. That is useful for when we want to measure the number of KV roundtrips and compare it to the expected number, but when we run the test cases as normal benchmarks the overhead of capturing a trace distorts all measurements.

Now we only capture traces when we need to, in the TestBenchmarkExpectation test.

Epic: None
Release note: None

The benchmarks in this package were all capturing statement traces. That
is useful for when we want to measure the number of KV roundtrips and
compare it to the expected number, but when we run the test cases as
normal benchmarks the overhead of capturing a trace distorts all
measurements.

Now we only capture traces when we need to, in the
TestBenchmarkExpectation test.

Release note: None
@rafiss rafiss requested a review from a team as a code owner December 30, 2024 19:28
Copy link

blathers-crl bot commented Dec 30, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss added backport-24.2.x Flags PRs that need to be backported to 24.2 backport-24.3.x Flags PRs that need to be backported to 24.3 labels Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-24.2.x Flags PRs that need to be backported to 24.2 backport-24.3.x Flags PRs that need to be backported to 24.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants